igb: Proactively round up to kmalloc bucket size
authorKees Cook <keescook@chromium.org>
Tue, 18 Oct 2022 09:25:25 +0000 (02:25 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Fri, 4 Nov 2022 18:09:57 +0000 (11:09 -0700)
In preparation for removing the "silently change allocation size"
users of ksize(), explicitly round up all q_vector allocations so that
allocations can be correctly compared to ksize().

Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igb/igb_main.c

index c2bb658..97290fc 100644 (file)
@@ -1195,7 +1195,7 @@ static int igb_alloc_q_vector(struct igb_adapter *adapter,
                return -ENOMEM;
 
        ring_count = txr_count + rxr_count;
-       size = struct_size(q_vector, ring, ring_count);
+       size = kmalloc_size_roundup(struct_size(q_vector, ring, ring_count));
 
        /* allocate q_vector and rings */
        q_vector = adapter->q_vector[v_idx];