Distinguish between system headers and project headers.

[Issue#] During compilation system and project headers were included the same way.
[Bug] N/A
[Cause] N/A
[Solution] Use -isystem flag to include system headers. In CMake files it's done by INCLUDE_DIRECTORY( SYSTEM ... ).
[Verification] Build commons. No warnings from system headers.

Change-Id: Ic8e35696f21da6674abc449e3ed272d07d050019

diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
index 4783a46c5c671293e9cd4f15bc55cde7376f3a9e..e71fc4c708b1e5c294b54b9021e5a52f87391d14 100644 (file)
--- a/3rdparty/CMakeLists.txt
+++ b/3rdparty/CMakeLists.txt
@@ -54,7 +54,7 @@ SET(TARGET_3RDPARTY "lib3rdparty")
 INCLUDE_DIRECTORIES(${DPL_3RDPARTY_INCLUDE_DIR})
 
 # Add system include files
-INCLUDE_DIRECTORIES(${SYS_3RDPARTY_INCLUDE_DIRS})
+INCLUDE_DIRECTORIES(SYSTEM ${SYS_3RDPARTY_INCLUDE_DIRS})
 LINK_DIRECTORIES(${SYS_3RDPARTY_LIBRARY_DIRS})
 
 # Build shared library

diff --git a/CMakeLists.txt b/CMakeLists.txt
index fc51d8ee7671fd7de114032cee2f1b05fea0b4f9..9a2b37d5b12162c58957e4254b2812414710a627 100644 (file)
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -170,7 +170,6 @@ ADD_DEFINITIONS("-std=c++0x")
 SET(DPL_3RDPARTY_INCLUDE_DIR
     ${PROJECT_SOURCE_DIR}/3rdparty)
 
-
 # Set names of binaries being created
 SET(TARGET_DPL_EFL "lib${PROJECT_NAME}-efl")
 SET(TARGET_DPL_DBUS_EFL "lib${PROJECT_NAME}-dbus-efl")

diff --git a/build/core/CMakeLists.txt b/build/core/CMakeLists.txt
index a202bdcf13b01b2420a03a3046cf402ac3407eb1..080d65ca1b254259d589e71c9a90b1d59006fa5a 100644 (file)
--- a/build/core/CMakeLists.txt
+++ b/build/core/CMakeLists.txt
@@ -35,9 +35,10 @@ INCLUDE_DIRECTORIES(
     ${DPL_LOG_INCLUDE_DIR}
     ${DPL_CORE_INCLUDE_DIR}
     ${DPL_3RDPARTY_INCLUDE_DIR}
-    ${SYS_EFL_INCLUDE_DIRS}
 )
 
+INCLUDE_DIRECTORIES(SYSTEM ${SYS_EFL_INCLUDE_DIRS})
+
 LINK_DIRECTORIES(${SYS_EFL_LIBRARY_DIRS})
 
 # Base EFL based DPL library

diff --git a/build/db/CMakeLists.txt b/build/db/CMakeLists.txt
index 6b38b8712f37c21ca1c39cb702179f607e02e042..29dd4955de3410858f4b742faa0536cf3a524a14 100644 (file)
--- a/build/db/CMakeLists.txt
+++ b/build/db/CMakeLists.txt
@@ -30,7 +30,10 @@ INCLUDE_DIRECTORIES(
     ${DPL_LOG_INCLUDE_DIR}
     ${DPL_CORE_INCLUDE_DIR}
     ${DPL_DB_INCLUDE_DIR}
-    ${SYS_EFL_INCLUDE_DIRS})
+)
+
+INCLUDE_DIRECTORIES(SYSTEM ${SYS_EFL_INCLUDE_DIRS})
+INCLUDE_DIRECTORIES(SYSTEM ${SYS_EFL_DB_INCLUDE_DIRS})
 
 LINK_DIRECTORIES(
     ${SYS_EFL_DB_LIBRARY_DIRS}

diff --git a/build/dbus/CMakeLists.txt b/build/dbus/CMakeLists.txt
index a7d0b635479a50068eb668ade11afde659043d43..59b2db11b7b9a27c85deec44888a849d7233f397 100644 (file)
--- a/build/dbus/CMakeLists.txt
+++ b/build/dbus/CMakeLists.txt
@@ -31,7 +31,10 @@ INCLUDE_DIRECTORIES(
     ${DPL_CORE_INCLUDE_DIR}
     ${DPL_DBUS_INCLUDE_DIR}
     ${DPL_EVENT_INCLUDE_DIR}
-    ${SYS_EFL_INCLUDE_DIRS})
+)
+
+INCLUDE_DIRECTORIES(SYSTEM ${SYS_EFL_INCLUDE_DIRS})
+INCLUDE_DIRECTORIES(SYSTEM ${SYS_EFL_DBUS_INCLUDE_DIRS})
 
 LINK_DIRECTORIES(
     ${SYS_EFL_DBUS_LIBRARY_DIRS}

diff --git a/build/encryption/CMakeLists.txt b/build/encryption/CMakeLists.txt
index 7994b273de3766c5807a525357e7030ac514e8a8..710ada6242beb930ccec059df76b87565a5fd54d 100644 (file)
--- a/build/encryption/CMakeLists.txt
+++ b/build/encryption/CMakeLists.txt
@@ -31,10 +31,11 @@ INCLUDE_DIRECTORIES(
     ${DPL_LOG_INCLUDE_DIR}
     ${DPL_CORE_INCLUDE_DIR}
     ${DPL_DB_INCLUDE_DIR}
-    ${SYS_ENCRYPTION_INCLUDE_DIRS}
     ${DPL_ENCRYPTION_INCLUDE_DIR}
 )
 
+INCLUDE_DIRECTORIES(SYSTEM ${SYS_ENCRYPTION_INCLUDE_DIRS})
+
 LINK_DIRECTORIES(
     ${SYS_ENCRYPTION_LIBRARY_DIRS}
 )

diff --git a/build/event/CMakeLists.txt b/build/event/CMakeLists.txt
index 1d18619f66bd81e51bda7ed501f3881b9125439b..b023e0ad4be64e30c480d36d705082d28a4ec9a3 100644 (file)
--- a/build/event/CMakeLists.txt
+++ b/build/event/CMakeLists.txt
@@ -32,7 +32,10 @@ INCLUDE_DIRECTORIES(
     ${DPL_LOG_INCLUDE_DIR}
     ${DPL_CORE_INCLUDE_DIR}
     ${DPL_EVENT_INCLUDE_DIR}
-    ${SYS_EFL_EVENT_INCLUDE_DIRS})
+    ${DPL_EVENT_INCLUDE_DIR}
+)
+
+INCLUDE_DIRECTORIES(SYSTEM ${SYS_EFL_EVENT_INCLUDE_DIRS})
 
 LINK_DIRECTORIES(
     ${SYS_EFL_EVENT_LIBRARY_DIRS}

diff --git a/build/log/CMakeLists.txt b/build/log/CMakeLists.txt
index 762f4791679e5a4b527888b21f365ccd9c8e02d5..47379d576449b78891377753cfb23481a95dc9bb 100644 (file)
--- a/build/log/CMakeLists.txt
+++ b/build/log/CMakeLists.txt
@@ -28,9 +28,10 @@ PKG_CHECK_MODULES(SYS_EFL_LOG
 # Add core include directories
 INCLUDE_DIRECTORIES(
     ${DPL_LOG_INCLUDE_DIR}
-    ${SYS_EFL_LOG_INCLUDE_DIRS}
 )
 
+INCLUDE_DIRECTORIES(SYSTEM ${SYS_EFL_LOG_INCLUDE_DIRS})
+
 LINK_DIRECTORIES(
     ${SYS_EFL_LOG_LIBRARY_DIRS}
 )

diff --git a/build/popup/CMakeLists.txt b/build/popup/CMakeLists.txt
index efb25aaa30492cd50d121cffd1d790ad313360e4..07425a3f6796358f414e4efbf971e9a2dc73e91f 100644 (file)
--- a/build/popup/CMakeLists.txt
+++ b/build/popup/CMakeLists.txt
@@ -30,7 +30,10 @@ INCLUDE_DIRECTORIES(
     ${DPL_CORE_INCLUDE_DIR}
     ${DPL_POPUP_INCLUDE_DIR}
     ${DPL_EVENT_INCLUDE_DIR}
-    ${SYS_EFL_INCLUDE_DIRS})
+)
+
+INCLUDE_DIRECTORIES(SYSTEM ${SYS_EFL_INCLUDE_DIRS})
+INCLUDE_DIRECTORIES(SYSTEM ${SYS_POPUP_INCLUDE_DIRS})
 
 LINK_DIRECTORIES(
     ${SYS_POPUP_LIBRARY_DIRS}

diff --git a/build/rpc/CMakeLists.txt b/build/rpc/CMakeLists.txt
index a782141a730bc752733aac5f0692774a9fc16475..9c52217cc9410a8d2fcdb4fd7ac6fa1f13d62ac7 100644 (file)
--- a/build/rpc/CMakeLists.txt
+++ b/build/rpc/CMakeLists.txt
@@ -1,3 +1,4 @@
+
 # Copyright (c) 2011 Samsung Electronics Co., Ltd All Rights Reserved
 #
 #    Licensed under the Apache License, Version 2.0 (the "License");
@@ -33,9 +34,10 @@ INCLUDE_DIRECTORIES(
     ${DPL_SOCKET_INCLUDE_DIR}
     ${DPL_EVENT_INCLUDE_DIR}
     ${DPL_RPC_INCLUDE_DIR}
-    ${SYS_EFL_RPC_INCLUDE_DIRS}
 )
 
+INCLUDE_DIRECTORIES(SYSTEM ${SYS_EFL_RPC_INCLUDE_DIRS})
+
 LINK_DIRECTORIES(
     ${SYS_EFL_RPC_LIBRARY_DIRS}
 )

diff --git a/build/socket/CMakeLists.txt b/build/socket/CMakeLists.txt
index d6198e3e9e3c82b7772d79e84a636099f8f3240f..3ef033f5de6da0c65800a42b79f8baf9ae0fa6cd 100644 (file)
--- a/build/socket/CMakeLists.txt
+++ b/build/socket/CMakeLists.txt
@@ -32,9 +32,10 @@ INCLUDE_DIRECTORIES(
     ${DPL_CORE_INCLUDE_DIR}
     ${DPL_SOCKET_INCLUDE_DIR}
     ${DPL_EVENT_INCLUDE_DIR}
-    ${SYS_EFL_SOCKET_INCLUDE_DIRS}
 )
 
+INCLUDE_DIRECTORIES(SYSTEM ${SYS_EFL_SOCKET_INCLUDE_DIRS})
+
 LINK_DIRECTORIES(
     ${SYS_EFL_SOCKET_LIBRARY_DIRS}
 )

diff --git a/build/test/CMakeLists.txt b/build/test/CMakeLists.txt
index 52fee0282b8499ad789d724da1b873027e692554..710fc4e58c74e39a8dd031ba9b39e1b778f32607 100644 (file)
--- a/build/test/CMakeLists.txt
+++ b/build/test/CMakeLists.txt
@@ -30,9 +30,10 @@ INCLUDE_DIRECTORIES(
     ${DPL_CORE_INCLUDE_DIR}
     ${DPL_TEST_ENGINE_INCLUDE_DIR}
     ${DPL_UTILS_INCLUDE_DIR}
-    ${SYS_EFL_TEST_ENGINE_INCLUDE_DIRS}
 )
 
+INCLUDE_DIRECTORIES(SYSTEM ${SYS_EFL_TEST_ENGINE_INCLUDE_DIRS})
+
 LINK_DIRECTORIES(
     ${SYS_EFL_TEST_ENGINE_LIBRARY_DIRS}
 )

diff --git a/build/utils/CMakeLists.txt b/build/utils/CMakeLists.txt
index 3e006ee947b082392e84f28857b65a81d512e8cd..ccc52ae0d3b47ebcb568c616afb7d00b675d9e6d 100644 (file)
--- a/build/utils/CMakeLists.txt
+++ b/build/utils/CMakeLists.txt
@@ -33,10 +33,10 @@ INCLUDE_DIRECTORIES(
     ${DPL_LOG_INCLUDE_DIR}
     ${DPL_CORE_INCLUDE_DIR}
     ${DPL_DB_INCLUDE_DIR}
-    ${SYS_EFL_UTILS_INCLUDE_DIRS}
     ${DPL_UTILS_INCLUDE_DIR}
     ${DPL_LOCALIZATION_INCLUDE_DIR}
 )
+INCLUDE_DIRECTORIES(SYSTEM ${SYS_EFL_UTILS_INCLUDE_DIRS})
 
 INCLUDE_DIRECTORIES(${PROJECT_SOURCE_DIR}/modules/widget_dao/include)
 INCLUDE_DIRECTORIES(${PROJECT_SOURCE_DIR}/modules/vcore/src/vcore)

diff --git a/modules/auto_save_dao/CMakeLists.txt b/modules/auto_save_dao/CMakeLists.txt
index 8685d57b89783a2800e1c47c2c77ac2a8334bc25..f137c600f6605b0f25d0683617568379f885fc31 100644 (file)
--- a/modules/auto_save_dao/CMakeLists.txt
+++ b/modules/auto_save_dao/CMakeLists.txt
@@ -37,9 +37,9 @@ SET(AUTO_SAVE_DAO_INCLUDE_DIRS
     ${PROJECT_SOURCE_DIR}/modules/core/include
     ${PROJECT_SOURCE_DIR}/modules/db/include
     ${PROJECT_SOURCE_DIR}/modules/log/include
-    ${AUTO_SAVE_DAO_DEPS_INCLUDE_DIRS}
 )
 
+
 SET(AUTO_SAVE_DAO_SOURCES
     dao/common_dao_types.cpp
     dao/AutoSaveDatabase.cpp
@@ -53,7 +53,9 @@ SET(AUTO_SAVE_DAO_RW_SOURCES
     dao/auto_save_dao.cpp
 )
 
+
 INCLUDE_DIRECTORIES(${AUTO_SAVE_DAO_INCLUDE_DIRS})
+INCLUDE_DIRECTORIES(SYSTEM ${AUTO_SAVE_DAO_DEPS_INCLUDE_DIRS})
 
 ADD_LIBRARY(${TARGET_AUTO_SAVE_DAO_LIB} SHARED ${AUTO_SAVE_DAO_SOURCES})
 SET_TARGET_PROPERTIES(${TARGET_AUTO_SAVE_DAO_LIB} PROPERTIES SOVERSION ${API_VERSION} VERSION ${VERSION})

diff --git a/modules/security_origin_dao/CMakeLists.txt b/modules/security_origin_dao/CMakeLists.txt
index f2a37da6e6f70a3bebfc214d8685dab39d7dcca4..161aa6b53b45d663659a6580065d4fb6530ef281 100644 (file)
--- a/modules/security_origin_dao/CMakeLists.txt
+++ b/modules/security_origin_dao/CMakeLists.txt
@@ -28,7 +28,6 @@ SET(SECURITY_ORIGIN_DAO_INCLUDE_DIRS
     ${PROJECT_SOURCE_DIR}/modules/db/include
     ${PROJECT_SOURCE_DIR}/modules/log/include
     ${PROJECT_SOURCE_DIR}/modules/widget_dao/include
-    ${SECURITY_ORIGIN_DAO_DEPS_INCLUDE_DIRS}
 )
 
 SET(SECURITY_ORIGIN_DAO_SOURCES
@@ -37,6 +36,7 @@ SET(SECURITY_ORIGIN_DAO_SOURCES
     dao/security_origin_dao.cpp
 )
 
+INCLUDE_DIRECTORIES(SYSTEM ${SECURITY_ORIGIN_DAO_DEPS_INCLUDE_DIRS} )
 INCLUDE_DIRECTORIES(${SECURITY_ORIGIN_DAO_INCLUDE_DIRS})
 
 ADD_LIBRARY(${TARGET_SECURITY_ORIGIN_DAO_LIB} SHARED ${SECURITY_ORIGIN_DAO_SOURCES})

diff --git a/modules/widget_dao/CMakeLists.txt b/modules/widget_dao/CMakeLists.txt
index c6f7057a6e5b27c409d2998f8e406841a9b8b393..6ef376542cd0880f0196d46b4c3a03863e66e048 100644 (file)
--- a/modules/widget_dao/CMakeLists.txt
+++ b/modules/widget_dao/CMakeLists.txt
@@ -68,10 +68,10 @@ SET(WRT_DAO_INCLUDE_DIRS
     ${PROJECT_SOURCE_DIR}/modules/db/include
     ${PROJECT_SOURCE_DIR}/modules/log/include
     ${PROJECT_SOURCE_DIR}/modules/localization/include
-    ${WRT_DAO_DEPS_INCLUDE_DIRS}
-    )
+)
 
 INCLUDE_DIRECTORIES(${WRT_DAO_INCLUDE_DIRS})
+INCLUDE_DIRECTORIES(SYSTEM ${WRT_DAO_DEPS_INCLUDE_DIRS})
 
 ADD_LIBRARY(${TARGET_WRT_DAO_RO_LIB} SHARED
             ${WRT_DAO_RO_SOURCES}