pwm: stm32: Don't modify HW state in .remove() callback
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 13 Jul 2023 15:51:41 +0000 (17:51 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Fri, 28 Jul 2023 07:46:21 +0000 (09:46 +0200)
A consumer is expected to disable a PWM before calling pwm_put(). And if
they didn't there is hopefully a good reason (or the consumer needs
fixing). Also if disabling an enabled PWM was the right thing to do,
this should better be done in the framework instead of in each low level
driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-stm32.c

index 62e397a..687967d 100644 (file)
@@ -649,10 +649,6 @@ static int stm32_pwm_probe(struct platform_device *pdev)
 static void stm32_pwm_remove(struct platform_device *pdev)
 {
        struct stm32_pwm *priv = platform_get_drvdata(pdev);
-       unsigned int i;
-
-       for (i = 0; i < priv->chip.npwm; i++)
-               pwm_disable(&priv->chip.pwms[i]);
 
        pwmchip_remove(&priv->chip);
 }