efl_ui_win: Fix dereference null return
authorChristopher Michael <cp.michael@samsung.com>
Fri, 15 Mar 2019 12:57:44 +0000 (08:57 -0400)
committerYeongjong Lee <yj34.lee@samsung.com>
Tue, 2 Apr 2019 03:45:17 +0000 (12:45 +0900)
Summary:
Coverity reports that efl_data_scope_safe_get returns NULL here
(checked 273 out of 285 times). Add an EINA_SAFETY check here before
trying to use 'sd'.

Fixes Coverity CID1399427

@fix

Depends on D8346

Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8347

src/lib/elementary/efl_ui_win.c

index 75cf1ba..1b1b7dc 100644 (file)
@@ -10973,6 +10973,7 @@ EAPI Eina_Bool
 elm_win_noblank_get(const Evas_Object *obj)
 {
    Efl_Ui_Win_Data *sd = efl_data_scope_safe_get(obj, MY_CLASS);
+   EINA_SAFETY_ON_NULL_RETURN_VAL(sd, EINA_FALSE);
    return sd->noblank;
 }