thermal/drivers/mediatek: Clean up redundant dev_err_probe()
authorChen Jiahao <chenjiahao16@huawei.com>
Wed, 2 Aug 2023 09:45:27 +0000 (17:45 +0800)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Wed, 16 Aug 2023 10:06:05 +0000 (12:06 +0200)
Referring to platform_get_irq()'s definition, the return value has
already been checked if ret < 0, and printed via dev_err_probe().
Calling dev_err_probe() one more time outside platform_get_irq()
is obviously redundant.

Removing dev_err_probe() outside platform_get_irq() to clean up
above problem.

Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230802094527.988842-1-chenjiahao16@huawei.com
drivers/thermal/mediatek/lvts_thermal.c

index bc726ac..f4709ae 100644 (file)
@@ -1216,7 +1216,7 @@ static int lvts_probe(struct platform_device *pdev)
 
        irq = platform_get_irq(pdev, 0);
        if (irq < 0)
-               return dev_err_probe(dev, irq, "No irq resource\n");
+               return irq;
 
        ret = lvts_domain_init(dev, lvts_td, lvts_data);
        if (ret)