Remove setAccurateVisibleContentsPosition codes because it is not needed anymore.
authorEunmi Lee <eunmi15.lee@samsung.com>
Thu, 21 Mar 2013 05:05:33 +0000 (14:05 +0900)
committerEunmi Lee <eunmi15.lee@samsung.com>
Tue, 26 Mar 2013 07:47:01 +0000 (16:47 +0900)
[Title] Remove setAccurateVisibleContentsPosition codes because it is not needed anymore.
[Issue#] N/A
[Problem] The setAccurateVisibleContentsPosition codes are not needed anymore.
[Cause] We call the initializeVisibleContentRect() and it set the accurateVisibleContentsPosition by
        calling setVisibleContentRect(), so we don't have to set accurateVisibleContentsPosition separately anymore.
        I know the setAccurateVisibleContentsPosition() is added for fixing N_SE-15113,
        and I've checked that defect does not occur without setAccurateVisibleContentsPosition() codes now.
[Solution] Remove setAccurateVisibleContentsPosition codes.

Change-Id: I6f4ebbe851276d826dede142306691993f10e4be

Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp
Source/WebKit2/UIProcess/DrawingAreaProxy.h
Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp
Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h
Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.cpp
Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.h
Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp
Source/WebKit2/UIProcess/WebLayerTreeRenderer.h

index 3e9ad46..c424c77 100644 (file)
@@ -1506,13 +1506,8 @@ void PageClientImpl::didRenderFrame()
         m_shouldShowBackupTexture = false;
 #endif
     if (!m_pageDidRendered) {
-        // adjustPositionForFixedLayers is calclulated based on m_drawingScrollPosition values which initially set.
-        // We need to set this values here, otherwise while navigating to new page, m_accurateVisibleContentsPosition will be having the previous scrolled position
-        // which makes positioning of the FixedLayer on wrong place
-        drawingArea()->setAccurateVisibleContentsPosition(FloatPoint(m_visibleContentRect.location()));
         m_pageDidRendered = true;
         initializeVisibleContentRect();
-
     }
 }
 
index e9485c9..5e20209 100755 (executable)
@@ -115,10 +115,6 @@ public:
     virtual void didSuspendPainting() { }
 #endif
 
-#if ENABLE(TIZEN_WEBKIT2_TILED_AC)
-    virtual void setAccurateVisibleContentsPosition(const WebCore::FloatPoint& accurateVisibleContentsPosition) { }
-#endif
-
 protected:
     explicit DrawingAreaProxy(DrawingAreaType, WebPageProxy*);
 
index ced2c5b..ce8814e 100755 (executable)
@@ -460,12 +460,4 @@ void DrawingAreaProxyImpl::didSuspendPainting()
 }
 #endif
 
-#if ENABLE(TIZEN_WEBKIT2_TILED_AC)
-void DrawingAreaProxyImpl::setAccurateVisibleContentsPosition(const WebCore::FloatPoint& accurateVisibleContentsPosition)
-{
-    if (m_layerTreeCoordinatorProxy)
-        m_layerTreeCoordinatorProxy->setAccurateVisibleContentsPosition(accurateVisibleContentsPosition);
-}
-#endif
-
 } // namespace WebKit
index 8d5c665..238f0c5 100755 (executable)
@@ -103,10 +103,6 @@ private:
     bool isInAcceleratedCompositingMode() const { return false; }
 #endif
 
-#if ENABLE(TIZEN_WEBKIT2_TILED_AC)
-    virtual void setAccurateVisibleContentsPosition(const WebCore::FloatPoint& accurateVisibleContentsPosition);
-#endif
-
     virtual void pageCustomRepresentationChanged();
 
     void discardBackingStoreSoon();
index 4286337..d775e25 100755 (executable)
@@ -281,13 +281,5 @@ void LayerTreeCoordinatorProxy::initializeAcceleratedCompositingMode(bool isGLMo
 }
 #endif
 
-#if ENABLE(TIZEN_WEBKIT2_TILED_AC)
-void LayerTreeCoordinatorProxy::setAccurateVisibleContentsPosition(const WebCore::FloatPoint& accurateVisibleContentsPosition)
-{
-    if (m_renderer)
-        m_renderer->setAccurateVisibleContentsPosition(accurateVisibleContentsPosition);
-}
-#endif
-
 }
 #endif // USE(UI_SIDE_COMPOSITING)
index 5945427..f5d8ca3 100755 (executable)
@@ -107,10 +107,6 @@ public:
     void initializeAcceleratedCompositingMode(bool isGLMode);
 #endif
 
-#if ENABLE(TIZEN_WEBKIT2_TILED_AC)
-    virtual void setAccurateVisibleContentsPosition(const WebCore::FloatPoint& accurateVisibleContentsPosition);
-#endif
-
 protected:
     void dispatchUpdate(const Function<void()>&);
 
index e50c37a..5583da4 100755 (executable)
@@ -320,13 +320,6 @@ void WebLayerTreeRenderer::setContentsSize(const WebCore::FloatSize& contentsSiz
     m_contentsSize = contentsSize;
 }
 
-#if ENABLE(TIZEN_WEBKIT2_TILED_AC)
-void WebLayerTreeRenderer::setAccurateVisibleContentsPosition(const WebCore::FloatPoint& accurateVisibleContentsPosition)
-{
-    m_accurateVisibleContentsPosition = accurateVisibleContentsPosition;
-}
-#endif
-
 void WebLayerTreeRenderer::setVisibleContentsRect(const IntRect& rect, float scale, const WebCore::FloatPoint& accurateVisibleContentsPosition)
 {
     m_visibleContentsRect = rect;
index d9c17e5..f3c73b2 100755 (executable)
@@ -158,10 +158,6 @@ public:
     void updateViewportFired();
 #endif
 
-#if ENABLE(TIZEN_WEBKIT2_TILED_AC)
-    virtual void setAccurateVisibleContentsPosition(const WebCore::FloatPoint& accurateVisibleContentsPosition);
-#endif
-
 private:
 #if ENABLE(TIZEN_RUNTIME_BACKEND_SELECTION)
 protected: