Bug 541507 – Ambiguous description of assigned characters in the Glib

2008-07-04  Behdad Esfahbod  <behdad@gnome.org>

        Bug 541507 – Ambiguous description of assigned characters in the Glib
        Unicode Manipulation reference

        * glib/guniprop.c
        (g_unichar_isgraph): Return true for PrivateUse too.
        (g_unichar_isprint): Return true for PrivateUse too.
        (g_unichar_isdefined): Return false for Surrogate.

svn path=/trunk/; revision=7161

diff --git a/ChangeLog b/ChangeLog
index ce7da120e80af78fcca82a9b04cb482dde1baae6..f851bd4dc5ac639f7a3f75031bc1199ceb10fcd7 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2008-07-04  Behdad Esfahbod  <behdad@gnome.org>
+
+       Bug 541507 – Ambiguous description of assigned characters in the Glib
+       Unicode Manipulation reference
+
+       * glib/guniprop.c
+       (g_unichar_isgraph): Return true for PrivateUse too.
+       (g_unichar_isprint): Return true for PrivateUse too.
+       (g_unichar_isdefined): Return false for Surrogate.
+
 2008-07-04  Michael Natterer  <mitch@imendio.com>
 
        Bug 541208 – Functions to easily install and use signals without

diff --git a/glib/guniprop.c b/glib/guniprop.c
index ae194c354631cff318b59a0e196a7a8c10261a30..57928e5182b927dd6dc607cbb68414799e8340f7 100644 (file)
--- a/glib/guniprop.c
+++ b/glib/guniprop.c
@@ -175,10 +175,9 @@ g_unichar_isgraph (gunichar c)
              OR (G_UNICODE_CONTROL,
              OR (G_UNICODE_FORMAT,
              OR (G_UNICODE_UNASSIGNED,
-             OR (G_UNICODE_PRIVATE_USE,
              OR (G_UNICODE_SURROGATE,
              OR (G_UNICODE_SPACE_SEPARATOR,
-            0)))))));
+            0))))));
 }
 
 /**
@@ -216,9 +215,8 @@ g_unichar_isprint (gunichar c)
              OR (G_UNICODE_CONTROL,
              OR (G_UNICODE_FORMAT,
              OR (G_UNICODE_UNASSIGNED,
-             OR (G_UNICODE_PRIVATE_USE,
              OR (G_UNICODE_SURROGATE,
-            0))))));
+            0)))));
 }
 
 /**
@@ -377,7 +375,10 @@ g_unichar_isxdigit (gunichar c)
 gboolean
 g_unichar_isdefined (gunichar c)
 {
-  return TYPE (c) != G_UNICODE_UNASSIGNED;
+  return !IS (TYPE(c),
+             OR (G_UNICODE_UNASSIGNED,
+             OR (G_UNICODE_SURROGATE,
+            0)));
 }
 
 /**