LRA: Implement commutative operands exchange for combining secondary memory reload...
authorVladimir N. Makarov <vmakarov@redhat.com>
Fri, 31 Mar 2023 15:04:44 +0000 (11:04 -0400)
committerVladimir N. Makarov <vmakarov@redhat.com>
Fri, 31 Mar 2023 15:05:45 +0000 (11:05 -0400)
The patch implements trying commutative operands exchange for
combining secondary memory reload and original insn.

        PR rtl-optimization/109052

gcc/ChangeLog:

* lra-constraints.cc: (combine_reload_insn): New function.

gcc/testsuite/ChangeLog:

* gcc.target/i386/pr109052-2.c: New.

gcc/lra-constraints.cc
gcc/testsuite/gcc.target/i386/pr109052-2.c [new file with mode: 0644]

index 405b8b92f5e6865daf91f1bfa4b064b92520fc73..ff4e8f06063682e4e240701e389e5014323ea0e8 100644 (file)
@@ -5061,7 +5061,23 @@ combine_reload_insn (rtx_insn *from, rtx_insn *to)
       curr_insn = to;
       curr_id = lra_get_insn_recog_data (curr_insn);
       curr_static_id = curr_id->insn_static_data;
-      ok_p = !curr_insn_transform (true);
+      for (bool swapped_p = false;;)
+       {
+         ok_p = !curr_insn_transform (true);
+         if (ok_p || curr_static_id->commutative < 0)
+           break;
+         swap_operands (curr_static_id->commutative);
+         if (lra_dump_file != NULL)
+           {
+             fprintf (lra_dump_file,
+                      "    Swapping %scombined insn operands:\n",
+                      swapped_p ? "back " : "");
+             dump_insn_slim (lra_dump_file, to);
+           }
+         if (swapped_p)
+           break;
+         swapped_p = true;
+       }
       curr_insn = saved_insn;
       curr_id = lra_get_insn_recog_data (curr_insn);
       curr_static_id = curr_id->insn_static_data;
diff --git a/gcc/testsuite/gcc.target/i386/pr109052-2.c b/gcc/testsuite/gcc.target/i386/pr109052-2.c
new file mode 100644 (file)
index 0000000..337d1f4
--- /dev/null
@@ -0,0 +1,10 @@
+/* { dg-do compile { target { ! ia32 } } } */
+/* { dg-options "-O2 -mfpmath=both -mavx -fno-math-errno" } */
+
+double foo (double a, double b)
+{
+  double z = __builtin_fmod (a, 3.14);
+  return z * b;
+}
+
+/* { dg-final { scan-assembler-not "vmulsd\[ \t]\+%xmm\[0-9]\+, %xmm\[0-9]\+, %xmm\[0-9]\+"} } */