scsi: lpfc: fix: Coverity: lpfc_get_scsi_buf_s3(): Null pointer dereferences
authorJames Smart <jsmart2021@gmail.com>
Mon, 11 Nov 2019 23:03:56 +0000 (15:03 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Jan 2020 07:22:58 +0000 (08:22 +0100)
commit 6f23f8c5c9f1be4eb17c035129c80e49000c18a7 upstream.

Coverity reported the following:

drivers/scsi/lpfc/lpfc_scsi.c

index aa82d53..40706cb 100644 (file)
@@ -719,7 +719,7 @@ lpfc_get_scsi_buf_s4(struct lpfc_hba *phba, struct lpfc_nodelist *ndlp,
        iocb->ulpLe = 1;
        iocb->ulpClass = CLASS3;
 
-       if (lpfc_ndlp_check_qdepth(phba, ndlp)) {
+       if (lpfc_ndlp_check_qdepth(phba, ndlp) && lpfc_cmd) {
                atomic_inc(&ndlp->cmd_pending);
                lpfc_cmd->flags |= LPFC_SBUF_BUMP_QDEPTH;
        }