crypto: arm/sha1-neon - Fix clang function cast warnings
authorHerbert Xu <herbert@gondor.apana.org.au>
Wed, 19 Apr 2023 09:27:40 +0000 (17:27 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 12 May 2023 10:48:01 +0000 (18:48 +0800)
Instead of casting the function which upsets clang for some reason,
change the assembly function siganture instead.

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304081828.zjGcFUyE-lkp@intel.com/
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/arm/crypto/sha1_neon_glue.c

index cfe36ae..9c70b87 100644 (file)
@@ -26,8 +26,8 @@
 
 #include "sha1.h"
 
-asmlinkage void sha1_transform_neon(void *state_h, const char *data,
-                                   unsigned int rounds);
+asmlinkage void sha1_transform_neon(struct sha1_state *state_h,
+                                   const u8 *data, int rounds);
 
 static int sha1_neon_update(struct shash_desc *desc, const u8 *data,
                          unsigned int len)
@@ -39,8 +39,7 @@ static int sha1_neon_update(struct shash_desc *desc, const u8 *data,
                return sha1_update_arm(desc, data, len);
 
        kernel_neon_begin();
-       sha1_base_do_update(desc, data, len,
-                           (sha1_block_fn *)sha1_transform_neon);
+       sha1_base_do_update(desc, data, len, sha1_transform_neon);
        kernel_neon_end();
 
        return 0;
@@ -54,9 +53,8 @@ static int sha1_neon_finup(struct shash_desc *desc, const u8 *data,
 
        kernel_neon_begin();
        if (len)
-               sha1_base_do_update(desc, data, len,
-                                   (sha1_block_fn *)sha1_transform_neon);
-       sha1_base_do_finalize(desc, (sha1_block_fn *)sha1_transform_neon);
+               sha1_base_do_update(desc, data, len, sha1_transform_neon);
+       sha1_base_do_finalize(desc, sha1_transform_neon);
        kernel_neon_end();
 
        return sha1_base_finish(desc, out);