Tests: It is useless to unset "DBUS_SESSION_BUS_ADDRESS" manually
authorXavier Claessens <xavier.claessens@collabora.co.uk>
Mon, 28 Oct 2013 21:02:44 +0000 (17:02 -0400)
committerXavier Claessens <xavier.claessens@collabora.co.uk>
Tue, 29 Oct 2013 17:42:35 +0000 (13:42 -0400)
If the goal is to make sure we don't have a dbus connection, it has
to call g_test_dbus_unset() instead which is much more complete.

In this case, g_test_dbus_unset() is called already, so it should be
fine.

https://bugzilla.gnome.org/show_bug.cgi?id=697348

gio/tests/gapplication.c

index 2d234bf..c9610c0 100644 (file)
@@ -449,8 +449,6 @@ test_actions (void)
   gchar *argv[] = { binpath, NULL };
   GApplication *app;
 
-  g_unsetenv ("DBUS_SESSION_BUS_ADDRESS");
-
   app = g_application_new ("org.gtk.Unimportant",
                            G_APPLICATION_FLAGS_NONE);
   g_signal_connect (app, "activate", G_CALLBACK (on_activate), NULL);
@@ -505,8 +503,6 @@ test_local_command_line (void)
   gchar *argv[] = { binpath, "-invalid", NULL };
   GApplication *app;
 
-  g_unsetenv ("DBUS_SESSION_BUS_ADDRESS");
-
   app = g_object_new (test_loc_cmd_app_get_type (),
                       "application-id", "org.gtk.Unimportant",
                       "flags", G_APPLICATION_FLAGS_NONE,