[NUI] Fix method to gether Views for transition
authorSeungho Baek <sbsh.baek@samsung.com>
Mon, 15 Nov 2021 05:29:19 +0000 (14:29 +0900)
committerdongsug-song <35130733+dongsug-song@users.noreply.github.com>
Wed, 17 Nov 2021 08:08:13 +0000 (17:08 +0900)
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
src/Tizen.NUI.Components/Controls/Navigation/Navigator.cs
test/Tizen.NUI.Samples/Tizen.NUI.Samples/Samples/PageTransitionSample.cs

index dcf0662..1be9928 100755 (executable)
@@ -755,26 +755,22 @@ namespace Tizen.NUI.Components
         /// </summary>
         /// <param name="taggedViews">Returned tagged view list..</param>
         /// <param name="view">Root View to get tagged child View.</param>
-        /// <param name="isPage">Flag to check current View is page or not</param>
-        private void RetrieveTaggedViews(List<View> taggedViews, View view, bool isPage)
+        /// <param name="isRoot">Flag to check current View is page or not</param>
+        private void RetrieveTaggedViews(List<View> taggedViews, View view, bool isRoot)
         {
-            if (!isPage)
+            if (!isRoot && view.TransitionOptions != null)
             {
                 if (!string.IsNullOrEmpty(view.TransitionOptions?.TransitionTag))
                 {
                     taggedViews.Add((view as View));
+                    if (view.TransitionOptions.TransitionWithChild)
+                    {
+                        return;
+                    }
                 }
 
-                if (view.ChildCount == 0)
-                {
-                    return;
-                }
-
-                if (view.TransitionOptions?.TransitionWithChild ?? false)
-                {
-                    return;
-                }
             }
+
             foreach (View child in view.Children)
             {
                 RetrieveTaggedViews(taggedViews, child, false);
index 54582d4..5288315 100755 (executable)
@@ -85,15 +85,12 @@ namespace Tizen.NUI.Samples
 
             TransitionGroup transitionGroup = new TransitionGroup()
             {
-                UseGroupTimePeriod = true,
                 UseGroupAlphaFunction = true,
-                StepTransition = true,
-                TimePeriod = new TimePeriod(500, 3000),
                 AlphaFunction = new AlphaFunction(AlphaFunction.BuiltinFunctions.EaseInOut),
             };
             SlideTransition slide = new SlideTransition()
             {
-                TimePeriod = new TimePeriod(1000),
+                TimePeriod = new TimePeriod(400),
                 AlphaFunction = new AlphaFunction(AlphaFunction.BuiltinFunctions.Default),
                 Direction = SlideTransitionDirection.Top
             };
@@ -101,14 +98,14 @@ namespace Tizen.NUI.Samples
             FadeTransition fade = new FadeTransition()
             {
                 Opacity = 0.3f,
-                TimePeriod = new TimePeriod(1000),
+                TimePeriod = new TimePeriod(400),
                 AlphaFunction = new AlphaFunction(AlphaFunction.BuiltinFunctions.Default)
             };
             transitionGroup.AddTransition(fade);
             ScaleTransition scale = new ScaleTransition()
             {
                 ScaleFactor = new Vector2(0.3f, 0.3f),
-                TimePeriod = new TimePeriod(1000),
+                TimePeriod = new TimePeriod(400),
                 AlphaFunction = new AlphaFunction(AlphaFunction.BuiltinFunctions.Default)
             };
             transitionGroup.AddTransition(scale);