staging: r8188eu: change declaration of Efuse_Read1ByteFromFakeContent
authorPhillip Potter <phil@philpotter.co.uk>
Sat, 21 Aug 2021 10:56:15 +0000 (11:56 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Aug 2021 10:18:43 +0000 (12:18 +0200)
Remove forward declaration of Efuse_Read1ByteFromFakeContent function
from core/rtw_efuse.c, as the function is defined in full directly
after this and therefore this forward declaration is redundant.

In addition, convert the storage class of the function to static, as the
function is only used with rtw_efuse.c, and tidy up the signature
alignment.

Acked-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: Michael Straube<straube.linux@gmail.com>
Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210821105615.6307-1-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_efuse.c

index decccf7..c1c7064 100644 (file)
@@ -29,17 +29,9 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
 #define REG_EFUSE_CTRL         0x0030
 #define EFUSE_CTRL                     REG_EFUSE_CTRL          /*  E-Fuse Control. */
 /*  */
-
-bool
-Efuse_Read1ByteFromFakeContent(
-                       struct adapter *pAdapter,
-                       u16 Offset,
-               u8 *Value);
-bool
-Efuse_Read1ByteFromFakeContent(
-                       struct adapter *pAdapter,
-                       u16 Offset,
-               u8 *Value)
+static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
+                                          u16 Offset,
+                                          u8 *Value)
 {
        if (Offset >= EFUSE_MAX_HW_SIZE)
                return false;