dlm: remove found label in dlm_master_lookup
authorAlexander Aring <aahringo@redhat.com>
Mon, 4 Apr 2022 20:06:44 +0000 (16:06 -0400)
committerDavid Teigland <teigland@redhat.com>
Wed, 6 Apr 2022 19:02:54 +0000 (14:02 -0500)
This patch cleanups a not necessary label found which can be replaced by
a proper else handling to jump over a specific code block.

Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com>
fs/dlm/lock.c

index fd3a9ba..25468b5 100644 (file)
@@ -954,18 +954,18 @@ int dlm_master_lookup(struct dlm_ls *ls, int from_nodeid, char *name, int len,
                hold_rsb(r);
                spin_unlock(&ls->ls_rsbtbl[b].lock);
                lock_rsb(r);
-               goto found;
-       }
+       } else {
+               error = dlm_search_rsb_tree(&ls->ls_rsbtbl[b].toss, name, len, &r);
+               if (error)
+                       goto not_found;
 
-       error = dlm_search_rsb_tree(&ls->ls_rsbtbl[b].toss, name, len, &r);
-       if (error)
-               goto not_found;
+               /* because the rsb is inactive (on toss list), it's not refcounted
+                * and lock_rsb is not used, but is protected by the rsbtbl lock
+                */
 
-       /* because the rsb is inactive (on toss list), it's not refcounted
-          and lock_rsb is not used, but is protected by the rsbtbl lock */
+               toss_list = 1;
+       }
 
-       toss_list = 1;
- found:
        if (r->res_dir_nodeid != our_nodeid) {
                /* should not happen, but may as well fix it and carry on */
                log_error(ls, "dlm_master_lookup res_dir %d our %d %s",