Fix svace issues 36/283236/2 accepted/tizen/unified/20221107.173040
authorSeonah Moon <seonah1.moon@samsung.com>
Thu, 20 Oct 2022 13:09:43 +0000 (22:09 +0900)
committerSeonah Moon <seonah1.moon@samsung.com>
Fri, 21 Oct 2022 09:34:50 +0000 (18:34 +0900)
- SEC_DO_NOT_USE_INT_IN_FOR_LOOP
- SEC_DO_NOT_CAST_LONG_TO_DOUBLE

Change-Id: I0b0fb1f1ccdd00f0281cc404c153cf35e58a7d7a

agent/download-agent-file.c
provider-interface/download-provider-interface.c

index 90782ff..4051150 100755 (executable)
@@ -957,15 +957,15 @@ da_ret_t get_available_memory(const char *dir_path, da_size_t len)
                //      return DA_ERR_INVALID_INSTALL_PATH;
        }
 
-       double available_size =  (double)filesys_info.f_frsize * filesys_info.f_bavail;
-       double total_size = (double)filesys_info.f_frsize * filesys_info.f_blocks;
-       DA_SECURE_LOGI(" total = %lf ", total_size);
-       DA_SECURE_LOGI(" available = %lf ", available_size);
+       long long available_size =  (long long)(filesys_info.f_frsize * filesys_info.f_bavail);
+       long long total_size = (long long)(filesys_info.f_frsize * filesys_info.f_blocks);
+       DA_SECURE_LOGI(" total = %llu ", total_size);
+       DA_SECURE_LOGI(" available = %llu ", available_size);
 
        DA_LOGV("Available Memory(f_bavail) : %llu", filesys_info.f_bavail);
        DA_LOGV("Available Memory(f_bsize) : %d", filesys_info.f_bsize);
        DA_LOGV("Content: %llu", len);
-       if (available_size < (len
+       if (available_size < (long long)(len
                                + SAVE_FILE_BUFFERING_SIZE_50KB)) /* 50KB buffering */
                ret = DA_ERR_DISK_FULL;
 
index dfb15e8..8179610 100755 (executable)
@@ -1648,7 +1648,7 @@ int dp_interface_get_http_header_field_list(const int id, char ***fields,
                                                errorcode = DP_ERROR_NO_DATA;
                                                *length = 0;
                                        } else {
-                                               int i = 0;
+                                               size_t i = 0;
                                                char **recv_strings = NULL;
 
                                                if (array_size > DOWNLOAD_HTTP_HEADER_FIELDS_MAX)
@@ -1694,7 +1694,7 @@ int dp_interface_get_http_header_field_list(const int id, char ***fields,
                                                        if (errorcode != DP_ERROR_IO_ERROR)
                                                                __bp_disconnect(__FUNCTION__); // clear IPC, can not expect the size of futher packets
                                                }
-                                               *length = i;
+                                               *length = (int)i;
                                        }
                                }
                        } else {