projects
/
platform
/
upstream
/
libHarfBuzzSharp.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b1e07e1
)
[util] Add empty virtual destructor to option_group_t
author
Behdad Esfahbod
<behdad@behdad.org>
Sun, 30 Sep 2018 09:46:20 +0000
(
05:46
-0400)
committer
Behdad Esfahbod
<behdad@behdad.org>
Sun, 30 Sep 2018 10:08:11 +0000
(06:08 -0400)
From clang -Weverything bot:
./options.hh:57:8: warning: 'option_group_t' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
struct option_group_t
^
util/options.hh
patch
|
blob
|
history
diff --git
a/util/options.hh
b/util/options.hh
index
456e0a0
..
0c929a2
100644
(file)
--- a/
util/options.hh
+++ b/
util/options.hh
@@
-56,6
+56,8
@@
void fail (hb_bool_t suggest_help, const char *format, ...) G_GNUC_NORETURN G_GN
struct option_group_t
{
+ virtual ~option_group_t () {}
+
virtual void add_options (struct option_parser_t *parser) = 0;
virtual void pre_parse (GError **error G_GNUC_UNUSED) {};