MIPS: Fix for StringCharCodeAtGenerator for vector-ics.
authorpaul.lind <paul.lind@imgtec.com>
Thu, 16 Apr 2015 16:06:56 +0000 (09:06 -0700)
committerCommit bot <commit-bot@chromium.org>
Thu, 16 Apr 2015 16:06:48 +0000 (16:06 +0000)
Register pop order bug only surfaced after vector-ic optimization
in https://codereview.chromium.org/1053843003 was landed.

TEST=mjsunit/string-index.js
BUG=

Review URL: https://codereview.chromium.org/1074123004

Cr-Commit-Position: refs/heads/master@{#27894}

src/mips/code-stubs-mips.cc
src/mips64/code-stubs-mips64.cc

index 6e7541fbc12407fd0795b6a1b1c8e0cd01b16066..ca0d2e94c08e3b5bdae24be13d9c6a3197715ddb 100644 (file)
@@ -3089,8 +3089,8 @@ void StringCharCodeAtGenerator::GenerateSlow(
   // have a chance to overwrite it.
   __ Move(index_, v0);
   if (FLAG_vector_ics && embed_mode == PART_OF_IC_HANDLER) {
-    __ Pop(VectorLoadICDescriptor::SlotRegister(),
-           VectorLoadICDescriptor::VectorRegister(), object_);
+    __ Pop(VectorLoadICDescriptor::VectorRegister(),
+           VectorLoadICDescriptor::SlotRegister(), object_);
   } else {
     __ pop(object_);
   }
index 02acdb0c4fbfc46c57a3a3319ab764e79f3b8da1..9cfef7d8d627b5b47c359ebddf5e29df9de01a6f 100644 (file)
@@ -3129,8 +3129,8 @@ void StringCharCodeAtGenerator::GenerateSlow(
 
   __ Move(index_, v0);
   if (FLAG_vector_ics && embed_mode == PART_OF_IC_HANDLER) {
-    __ Pop(VectorLoadICDescriptor::SlotRegister(),
-           VectorLoadICDescriptor::VectorRegister(), object_);
+    __ Pop(VectorLoadICDescriptor::VectorRegister(),
+           VectorLoadICDescriptor::SlotRegister(), object_);
   } else {
     __ pop(object_);
   }