scsi: hptiop: Switch to attribute groups
authorBart Van Assche <bvanassche@acm.org>
Tue, 12 Oct 2021 23:35:34 +0000 (16:35 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:45:55 +0000 (21:45 -0400)
struct device supports attribute groups directly but does not support
struct device_attribute directly. Hence switch to attribute groups.

Link: https://lore.kernel.org/r/20211012233558.4066756-23-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hptiop.c

index f9a9def..d04245e 100644 (file)
@@ -1146,12 +1146,14 @@ static struct device_attribute hptiop_attr_fw_version = {
        .show = hptiop_show_fw_version,
 };
 
-static struct device_attribute *hptiop_attrs[] = {
-       &hptiop_attr_version,
-       &hptiop_attr_fw_version,
+static struct attribute *hptiop_host_attrs[] = {
+       &hptiop_attr_version.attr,
+       &hptiop_attr_fw_version.attr,
        NULL
 };
 
+ATTRIBUTE_GROUPS(hptiop_host);
+
 static int hptiop_slave_config(struct scsi_device *sdev)
 {
        if (sdev->type == TYPE_TAPE)
@@ -1168,7 +1170,7 @@ static struct scsi_host_template driver_template = {
        .info                       = hptiop_info,
        .emulated                   = 0,
        .proc_name                  = driver_name,
-       .shost_attrs                = hptiop_attrs,
+       .shost_groups               = hptiop_host_groups,
        .slave_configure            = hptiop_slave_config,
        .this_id                    = -1,
        .change_queue_depth         = hptiop_adjust_disk_queue_depth,