Make code safe for -Wredundant-decls

Adds that warning to configure.ac

Includes a tiny change of the GST_BOILERPLATE_FULL() macro:
The get_type() function is no longer declared before being defined.

https://bugzilla.gnome.org/show_bug.cgi?id=611692

diff --git a/configure.ac b/configure.ac
index 2de8b65de8ac4145ff2a42d2619980327598e8d3..29706b0de5c4a2f8c1b90e9a630526c66aab509f 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -578,7 +578,7 @@ GST_PKG_DEPS="glib-2.0, gobject-2.0, gmodule-no-export-2.0, gthread-2.0"
 AC_SUBST(GST_PKG_DEPS)
 
 dnl define an ERROR_CFLAGS Makefile variable
-AG_GST_SET_ERROR_CFLAGS($GST_GIT)
+AG_GST_SET_ERROR_CFLAGS($GST_GIT, [-Wredundant-decls])
 
 dnl define correct level for debugging messages
 AG_GST_SET_LEVEL_DEFAULT($GST_GIT)

diff --git a/docs/gst/gstreamer-sections.txt b/docs/gst/gstreamer-sections.txt
index 3f593f86e54a2cc68742aad852da40970c16c297..9c53f5e567dc906cc360821df2beb4fb90207fd9 100644 (file)
--- a/docs/gst/gstreamer-sections.txt
+++ b/docs/gst/gstreamer-sections.txt
@@ -1962,8 +1962,6 @@ gst_registry_find_feature
 gst_registry_lookup_feature
 gst_registry_add_path
 gst_registry_scan_path
-gst_registry_binary_read_cache
-gst_registry_binary_write_cache
 gst_registry_lookup
 gst_registry_remove_feature
 gst_registry_add_feature

diff --git a/gst/gstbus.c b/gst/gstbus.c
index 9991a7d6e29516e606f9bacdcc82816ef8bc65d9..7a21ab1cca4cdb13c756695ec453b0e6ce6884f5 100644 (file)
--- a/gst/gstbus.c
+++ b/gst/gstbus.c
@@ -88,8 +88,6 @@ enum
   LAST_SIGNAL
 };
 
-static void gst_bus_class_init (GstBusClass * klass);
-static void gst_bus_init (GstBus * bus);
 static void gst_bus_dispose (GObject * object);
 
 static void gst_bus_set_main_context (GstBus * bus, GMainContext * ctx);

diff --git a/gst/gstclock.c b/gst/gstclock.c
index e42aa17fe0e85ea45372fcc314c654cf5249f529..925823f43e3b649387889f91ab7a1e84683e9db0 100644 (file)
--- a/gst/gstclock.c
+++ b/gst/gstclock.c
@@ -167,8 +167,6 @@ G_STMT_START {                                    \
   GST_OBJECT_UNLOCK (clock);                      \
 } G_STMT_END;
 
-static void gst_clock_class_init (GstClockClass * klass);
-static void gst_clock_init (GstClock * clock);
 static void gst_clock_dispose (GObject * object);
 static void gst_clock_finalize (GObject * object);
 

diff --git a/gst/gstelementfactory.c b/gst/gstelementfactory.c
index 3a87790e50ca201ca7ddca71681d674694736086..0483eef0cd5688f66bfec618cb6e0276e9e95990 100644 (file)
--- a/gst/gstelementfactory.c
+++ b/gst/gstelementfactory.c
@@ -69,8 +69,6 @@
 GST_DEBUG_CATEGORY_STATIC (element_factory_debug);
 #define GST_CAT_DEFAULT element_factory_debug
 
-static void gst_element_factory_class_init (GstElementFactoryClass * klass);
-static void gst_element_factory_init (GstElementFactory * factory);
 static void gst_element_factory_finalize (GObject * object);
 void __gst_element_details_clear (GstElementDetails * dp);
 static void gst_element_factory_cleanup (GstElementFactory * factory);

diff --git a/gst/gstindex.c b/gst/gstindex.c
index 0a70c3b3e20188d17a8e3c8cde0b79889bb3222a..a1c0dd3ac5f0f22d598245b58198f81792f47325 100644 (file)
--- a/gst/gstindex.c
+++ b/gst/gstindex.c
@@ -58,8 +58,6 @@ enum
 GST_DEBUG_CATEGORY_STATIC (index_debug);
 #define GST_CAT_DEFAULT index_debug
 
-static void gst_index_class_init (GstIndexClass * klass);
-static void gst_index_init (GstIndex * index);
 static void gst_index_finalize (GObject * object);
 
 static void gst_index_set_property (GObject * object, guint prop_id,

diff --git a/gst/gstindexfactory.c b/gst/gstindexfactory.c
index 97083d774180cae755d2ff0ea3f912357e091535..a8234ff46fdbfcfff80500e4f4e14510820d6cf4 100644 (file)
--- a/gst/gstindexfactory.c
+++ b/gst/gstindexfactory.c
@@ -37,7 +37,6 @@
 #include "gstmarshal.h"
 #include "gstregistry.h"
 
-static void gst_index_factory_class_init (GstIndexFactoryClass * klass);
 static void gst_index_factory_finalize (GObject * object);
 
 static GstPluginFeatureClass *factory_parent_class = NULL;

diff --git a/gst/gstinfo.c b/gst/gstinfo.c
index e80da43e14a4109b31a1153b4769826d403b2bf4..b1362076838cca8e34c3488b07d3dde3c65d9dc2 100644 (file)
--- a/gst/gstinfo.c
+++ b/gst/gstinfo.c
@@ -1493,12 +1493,9 @@ _gst_debug_get_category (const gchar * name)
 static GHashTable *__gst_function_pointers;     /* NULL */
 static GStaticMutex __dbg_functions_mutex = G_STATIC_MUTEX_INIT;
 
-const gchar *
-_gst_debug_nameof_funcptr (GstDebugFuncPtr ptr)
-    G_GNUC_NO_INSTRUMENT;
-
 /* This function MUST NOT return NULL */
-     const gchar *_gst_debug_nameof_funcptr (GstDebugFuncPtr func)
+const gchar *
+_gst_debug_nameof_funcptr (GstDebugFuncPtr func)
 {
   gchar *ptrname;
 

diff --git a/gst/gstinfo.h b/gst/gstinfo.h
index 6266014d289aad144c2e4a9cd3d0ab939270a97e..cfd621a16c51f5900eee3f4f149c02ec4dd0de4c 100644 (file)
--- a/gst/gstinfo.h
+++ b/gst/gstinfo.h
@@ -1098,7 +1098,7 @@ typedef   void (* GstDebugFuncPtr)        (void);
 void   _gst_debug_register_funcptr     (GstDebugFuncPtr        func,
                                         const gchar *          ptrname);
 G_CONST_RETURN gchar *
-       _gst_debug_nameof_funcptr       (GstDebugFuncPtr        func);
+       _gst_debug_nameof_funcptr       (GstDebugFuncPtr        func) G_GNUC_NO_INSTRUMENT;
 
 /**
  * GST_DEBUG_REGISTER_FUNCPTR:

diff --git a/gst/gstobject.c b/gst/gstobject.c
index 84d1dbb3f7b68a6a24adc2abba6dfb5758190700..a8c8c04e76f039eb26f3544d8ab9c8a7748a098a 100644 (file)
--- a/gst/gstobject.c
+++ b/gst/gstobject.c
@@ -133,8 +133,6 @@ typedef struct _GstSignalObject GstSignalObject;
 typedef struct _GstSignalObjectClass GstSignalObjectClass;
 
 static GType gst_signal_object_get_type (void);
-static void gst_signal_object_class_init (GstSignalObjectClass * klass);
-static void gst_signal_object_init (GstSignalObject * object);
 
 #ifndef GST_DISABLE_LOADSAVE
 static guint gst_signal_object_signals[SO_LAST_SIGNAL] = { 0 };

diff --git a/gst/gstpipeline.c b/gst/gstpipeline.c
index 82f5433c9bb889e7a3d284daf440e4e7d11b9dea..639fe502b0f47423b98426f7d3d1aaa6cbf830a2 100644 (file)
--- a/gst/gstpipeline.c
+++ b/gst/gstpipeline.c
@@ -125,8 +125,6 @@ struct _GstPipelinePrivate
 };
 
 
-static void gst_pipeline_base_init (gpointer g_class);
-
 static void gst_pipeline_dispose (GObject * object);
 static void gst_pipeline_set_property (GObject * object, guint prop_id,
     const GValue * value, GParamSpec * pspec);

diff --git a/gst/gstplugin.c b/gst/gstplugin.c
index 847dea0bd33820e195ed953ff1ea117aa97eacbb..a4af2f3db3915021ceb564f61a910eec955f7a18 100644 (file)
--- a/gst/gstplugin.c
+++ b/gst/gstplugin.c
@@ -513,8 +513,6 @@ _gst_plugin_fault_handler_setup (void)
 }
 #endif /* HAVE_SIGACTION */
 
-static void _gst_plugin_fault_handler_setup ();
-
 static GStaticMutex gst_plugin_loading_mutex = G_STATIC_MUTEX_INIT;
 
 #define CHECK_PLUGIN_DESC_FIELD(desc,field,fn)                               \

diff --git a/gst/gstregistry.c b/gst/gstregistry.c
index a4048dae07dd46acb18500ccd49bcb0a0ecff0c2..4e27f5da034d000cf0e7b0be007c7475956b4164 100644 (file)
--- a/gst/gstregistry.c
+++ b/gst/gstregistry.c
@@ -114,11 +114,7 @@
 
 #include "gst-i18n-lib.h"
 
-/* needed for fast retrieval of element and typefind factory lists */
-extern GType gst_type_find_factory_get_type (void);
-#define GST_TYPE_TYPE_FIND_FACTORY                 (gst_type_find_factory_get_type())
-extern GType gst_element_factory_get_type (void);
-#define GST_TYPE_ELEMENT_FACTORY                 (gst_element_factory_get_type())
+#include "gst.h"
 
 #ifdef G_OS_WIN32
 #include <windows.h>

diff --git a/gst/gstregistrybinary.h b/gst/gstregistrybinary.h
index f2e207deeba51cdc08d14cc087118b4ef19c52c5..1d9dae6244bde618e252bee5cfc96a3e0446510b 100644 (file)
--- a/gst/gstregistrybinary.h
+++ b/gst/gstregistrybinary.h
@@ -70,10 +70,6 @@ typedef struct _GstBinaryRegistryMagic
   gchar version[GST_MAGIC_BINARY_VERSION_LEN];
 } GstBinaryRegistryMagic;
 
-/* Function prototypes */
-gboolean gst_registry_binary_write_cache(GstRegistry *registry, const char *location);
-gboolean gst_registry_binary_read_cache(GstRegistry *registry, const char *location);
-
 G_END_DECLS
 
 #endif /* !__GST_REGISTRYBINARY_H__ */

diff --git a/gst/gstsystemclock.c b/gst/gstsystemclock.c
index aa48acf1a9e12beb22d2fe5a5d76c51dc806e760..87fb4d77909b1174ee31ceb8a8f40b7fa2b18294 100644 (file)
--- a/gst/gstsystemclock.c
+++ b/gst/gstsystemclock.c
@@ -93,8 +93,6 @@ enum
 /* the one instance of the systemclock */
 static GstClock *_the_system_clock = NULL;
 
-static void gst_system_clock_class_init (GstSystemClockClass * klass);
-static void gst_system_clock_init (GstSystemClock * clock);
 static void gst_system_clock_dispose (GObject * object);
 static void gst_system_clock_set_property (GObject * object, guint prop_id,
     const GValue * value, GParamSpec * pspec);

diff --git a/gst/gsttask.c b/gst/gsttask.c
index 9026502330834af04e98644bd0aa02e25d40cda8..86059ed2ed7f3c2639e436a9bc2fec84ab3a4957 100644 (file)
--- a/gst/gsttask.c
+++ b/gst/gsttask.c
@@ -92,8 +92,6 @@ struct _GstTaskPrivate
   GstTaskPool *pool_id;
 };
 
-static void gst_task_class_init (GstTaskClass * klass);
-static void gst_task_init (GstTask * task);
 static void gst_task_finalize (GObject * object);
 
 static void gst_task_func (GstTask * task);

diff --git a/gst/gsttaskpool.c b/gst/gsttaskpool.c
index c183ab19669699a74105906f356e91773ca768f5..992ef31dbc86d416d098754ebe6a40db4c45b93b 100644 (file)
--- a/gst/gsttaskpool.c
+++ b/gst/gsttaskpool.c
@@ -40,8 +40,6 @@
 GST_DEBUG_CATEGORY_STATIC (taskpool_debug);
 #define GST_CAT_DEFAULT (taskpool_debug)
 
-static void gst_task_pool_class_init (GstTaskPoolClass * klass);
-static void gst_task_pool_init (GstTaskPool * pool);
 static void gst_task_pool_finalize (GObject * object);
 
 #define _do_init \

diff --git a/gst/gstutils.h b/gst/gstutils.h
index 89dba5d08cf90c7bd8f7d68aca0e9fc053187354..74aab3a12fba8b4bd5256d061a34af6238c25bf7 100644 (file)
--- a/gst/gstutils.h
+++ b/gst/gstutils.h
@@ -131,8 +131,6 @@ type_as_function ## _class_init_trampoline (gpointer g_class,               \
   type_as_function ## _class_init ((type ## Class *)g_class);          \
 }                                                                      \
                                                                        \
-GType type_as_function ## _get_type (void);                            \
-                                                                       \
 GType                                                                  \
 type_as_function ## _get_type (void)                                   \
 {                                                                      \

diff --git a/gst/gstxml.c b/gst/gstxml.c
index 04522fd3bfe541e30b816ab2b748232e45735c1a..8c820efc276691b7515c692201cd16b6f433c96c 100644 (file)
--- a/gst/gstxml.c
+++ b/gst/gstxml.c
@@ -47,8 +47,6 @@ enum
   LAST_SIGNAL
 };
 
-static void gst_xml_class_init (GstXMLClass * klass);
-static void gst_xml_init (GstXML * xml);
 static void gst_xml_dispose (GObject * object);
 
 static void gst_xml_object_loaded (GstObject * private, GstObject * object,

diff --git a/gst/parse/grammar.y b/gst/parse/grammar.y
index 81a5e2a62fc7ba4e48389d63b8d3d2016c5dd21f..2be3b5f0fa93982473363eae0908fa6e94c92fe5 100644 (file)
--- a/gst/parse/grammar.y
+++ b/gst/parse/grammar.y
@@ -37,7 +37,6 @@ struct yy_buffer_state * _gst_parse_yy_scan_string (char* , yyscan_t);
 void _gst_parse_yypush_buffer_state (void * new_buffer ,yyscan_t yyscanner );
 void _gst_parse_yypop_buffer_state (yyscan_t yyscanner );
 
-
 #ifdef __GST_PARSE_TRACE
 static guint __strings;
 static guint __links;

diff --git a/libs/gst/base/gstcollectpads.c b/libs/gst/base/gstcollectpads.c
index f9aa1168a4202bbb578d38c7b2b17791c08455e6..5768fffd3eb39dfc975fcf853f15a70f48040c42 100644 (file)
--- a/libs/gst/base/gstcollectpads.c
+++ b/libs/gst/base/gstcollectpads.c
@@ -93,8 +93,6 @@ static void gst_collect_pads_clear (GstCollectPads * pads,
 static GstFlowReturn gst_collect_pads_chain (GstPad * pad, GstBuffer * buffer);
 static gboolean gst_collect_pads_event (GstPad * pad, GstEvent * event);
 static void gst_collect_pads_finalize (GObject * object);
-static void gst_collect_pads_init (GstCollectPads * pads,
-    GstCollectPadsClass * g_class);
 static void ref_data (GstCollectData * data);
 static void unref_data (GstCollectData * data);
 static void gst_collect_pads_check_pads_unlocked (GstCollectPads * pads);

diff --git a/libs/gst/controller/gstcontrolsource.c b/libs/gst/controller/gstcontrolsource.c
index 284c0847fe511751011f8bd5cda8fb0b452f3dfa..0d7d47a45447a163883ccd7730989d9839fa99ce 100644 (file)
--- a/libs/gst/controller/gstcontrolsource.c
+++ b/libs/gst/controller/gstcontrolsource.c
@@ -49,9 +49,6 @@
 #define GST_CAT_DEFAULT controller_debug
 GST_DEBUG_CATEGORY_EXTERN (GST_CAT_DEFAULT);
 
-static void gst_control_source_class_init (GstControlSourceClass * klass);
-static void gst_control_source_init (GstControlSource * self);
-
 G_DEFINE_ABSTRACT_TYPE (GstControlSource, gst_control_source, G_TYPE_OBJECT);
 
 static GObjectClass *parent_class = NULL;

diff --git a/libs/gst/controller/gstinterpolationcontrolsource.c b/libs/gst/controller/gstinterpolationcontrolsource.c
index 1c7436bec580f029347d0008076fa16df64d3666..8f7d1d86f6fe1f67ee4cde96cb139ea5cf24965a 100644 (file)
--- a/libs/gst/controller/gstinterpolationcontrolsource.c
+++ b/libs/gst/controller/gstinterpolationcontrolsource.c
@@ -47,12 +47,6 @@
 #define GST_CAT_DEFAULT controller_debug
 GST_DEBUG_CATEGORY_EXTERN (GST_CAT_DEFAULT);
 
-static void gst_interpolation_control_source_init (GstInterpolationControlSource
-    * self);
-static void
-gst_interpolation_control_source_class_init (GstInterpolationControlSourceClass
-    * klass);
-
 G_DEFINE_TYPE (GstInterpolationControlSource, gst_interpolation_control_source,
     GST_TYPE_CONTROL_SOURCE);
 

diff --git a/libs/gst/controller/gstlfocontrolsource.c b/libs/gst/controller/gstlfocontrolsource.c
index f3e1f223975d1d1fd363d952cbd0c13c62bff5b8..b725500314b737f51892540ebe216f00c42c9310 100644 (file)
--- a/libs/gst/controller/gstlfocontrolsource.c
+++ b/libs/gst/controller/gstlfocontrolsource.c
@@ -602,10 +602,6 @@ gst_lfo_waveform_get_type (void)
   return gtype;
 }
 
-static void gst_lfo_control_source_init (GstLFOControlSource * self);
-static void
-gst_lfo_control_source_class_init (GstLFOControlSourceClass * klass);
-
 G_DEFINE_TYPE (GstLFOControlSource, gst_lfo_control_source,
     GST_TYPE_CONTROL_SOURCE);
 

diff --git a/libs/gst/dataprotocol/dp-private.h b/libs/gst/dataprotocol/dp-private.h
index 92a78674c101eb93934cb22c9b9369cfb9223aef..5e54045cf5dde7ac4d4bfbc4521e231ef608476c 100644 (file)
--- a/libs/gst/dataprotocol/dp-private.h
+++ b/libs/gst/dataprotocol/dp-private.h
@@ -44,7 +44,6 @@ G_BEGIN_DECLS
 #define GST_DP_HEADER_CRC_HEADER(x)     GST_READ_UINT16_BE (x + 58)
 #define GST_DP_HEADER_CRC_PAYLOAD(x)    GST_READ_UINT16_BE (x + 60)
 
-void gst_dp_init (void);
 void gst_dp_dump_byte_array (guint8 *array, guint length);
 
 G_END_DECLS

diff --git a/tests/check/elements/fakesink.c b/tests/check/elements/fakesink.c
index c0b603ff9b3cb7875f93206626f5f1e4491c4e98..461c0245d27241a7485659be33060cb23eba7d4e 100644 (file)
--- a/tests/check/elements/fakesink.c
+++ b/tests/check/elements/fakesink.c
@@ -864,6 +864,7 @@ GST_END_TEST;
 typedef GstPushSrc OOBSource;
 typedef GstPushSrcClass OOBSourceClass;
 
+GType oob_source_get_type (void);
 GST_BOILERPLATE (OOBSource, oob_source, GstPushSrc, GST_TYPE_PUSH_SRC);
 
 static void

diff --git a/tests/check/gst/gstparamspecs.c b/tests/check/gst/gstparamspecs.c
index 0b6527d2f510719381b7b10760bd9af5c43133dd..545bce5a5951a070f1dabd708c24c93188496dcc 100644 (file)
--- a/tests/check/gst/gstparamspecs.c
+++ b/tests/check/gst/gstparamspecs.c
@@ -32,6 +32,7 @@ typedef struct
 
 typedef GstElementClass GstDummyObjClass;
 
+GType gst_dummy_obj_get_type (void);
 GST_BOILERPLATE (GstDummyObj, gst_dummy_obj, GstElement, GST_TYPE_ELEMENT);
 
 static void

diff --git a/tests/check/gst/gsttagsetter.c b/tests/check/gst/gsttagsetter.c
index fd230dff391b7f05736bf16afda739174ec2802c..48c13087ddcc33f160bbb62b45b1faa93527b56a 100644 (file)
--- a/tests/check/gst/gsttagsetter.c
+++ b/tests/check/gst/gsttagsetter.c
@@ -29,6 +29,7 @@ typedef GstElementClass GstDummyEncClass;
 
 static void gst_dummy_enc_add_interfaces (GType enc_type);
 
+GType gst_dummy_enc_get_type (void);
 GST_BOILERPLATE_FULL (GstDummyEnc, gst_dummy_enc, GstElement,
     GST_TYPE_ELEMENT, gst_dummy_enc_add_interfaces);
 
@@ -221,6 +222,7 @@ GST_START_TEST (test_merge_modes_skip_empty)
     }
   }
 }
+
 GST_END_TEST static Suite *
 gst_tag_setter_suite (void)
 {

diff --git a/tests/check/libs/test_transform.c b/tests/check/libs/test_transform.c
index 76c7404bf56d198f5f179b5a04ae9f5e98fcae58..960416470ba858b1d72a32d29dd8178164efad3a 100644 (file)
--- a/tests/check/libs/test_transform.c
+++ b/tests/check/libs/test_transform.c
@@ -55,6 +55,8 @@ struct _GstTestTransClass
   GstBaseTransformClass parent_class;
 };
 
+GType gst_test_trans_get_type (void);
+
 GST_BOILERPLATE (GstTestTrans, gst_test_trans, GstBaseTransform,
     GST_TYPE_BASE_TRANSFORM);
 

diff --git a/tests/examples/streams/testrtpool.c b/tests/examples/streams/testrtpool.c
index 995a2f54cd1fc511ba490481ccd6a46928b068c9..f2e6fa5dfb9655e3d36e6a39de712c3aa72f2767 100644 (file)
--- a/tests/examples/streams/testrtpool.c
+++ b/tests/examples/streams/testrtpool.c
@@ -21,8 +21,6 @@
 
 #include "testrtpool.h"
 
-static void test_rt_pool_class_init (TestRTPoolClass * klass);
-static void test_rt_pool_init (TestRTPool * pool);
 static void test_rt_pool_finalize (GObject * object);
 
 typedef struct