zink: inject LOD for sampler version of OpImageQuerySize
authorMike Blumenkrantz <michael.blumenkrantz@gmail.com>
Thu, 28 Oct 2021 14:57:01 +0000 (10:57 -0400)
committerMarge Bot <emma+marge@anholt.net>
Fri, 29 Oct 2021 19:05:07 +0000 (19:05 +0000)
this is required by spec

cc: mesa-stable

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13585>

src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c

index c09e346..b03dca5 100644 (file)
@@ -2980,6 +2980,14 @@ emit_tex(struct ntv_context *ctx, nir_tex_instr *tex)
       lod = emit_float_const(ctx, 32, 0.0);
    if (tex->op == nir_texop_txs) {
       SpvId image = spirv_builder_emit_image(&ctx->builder, image_type, load);
+      /* Additionally, if its Dim is 1D, 2D, 3D, or Cube,
+       * it must also have either an MS of 1 or a Sampled of 0 or 2.
+       * - OpImageQuerySize specification
+       *
+       * all spirv samplers use these types
+       */
+      if (tex->sampler_dim != GLSL_SAMPLER_DIM_MS && !lod)
+         lod = emit_uint_const(ctx, 32, 0);
       SpvId result = spirv_builder_emit_image_query_size(&ctx->builder,
                                                          dest_type, image,
                                                          lod);