openh264enc: set GST_PARAM_MUTABLE_PLAYING for bitrate/max-bitrate properties
authorNicola Murino <nicola.murino@gmail.com>
Mon, 17 Jul 2017 22:52:03 +0000 (00:52 +0200)
committerOlivier CrĂȘte <olivier.crete@collabora.com>
Mon, 17 Jul 2017 23:13:19 +0000 (19:13 -0400)
This way is documented that these properties can be changed in any state

https://bugzilla.gnome.org/show_bug.cgi?id=784988

ext/openh264/gstopenh264enc.cpp

index 51f038d1b885158c75e7b8382016834f3acba188..aa8138d7d6233a8e8ad38a9babfffd447965d479 100644 (file)
@@ -296,13 +296,15 @@ gst_openh264enc_class_init (GstOpenh264EncClass * klass)
       g_param_spec_uint ("bitrate", "Bitrate",
           "Bitrate (in bits per second)",
           0, G_MAXUINT, DEFAULT_BITRATE,
-          (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)));
+          (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS |
+              GST_PARAM_MUTABLE_PLAYING)));
 
   g_object_class_install_property (gobject_class, PROP_MAX_BITRATE,
       g_param_spec_uint ("max-bitrate", "Max Bitrate",
           "Maximum Bitrate (in bits per second)",
           0, G_MAXUINT, DEFAULT_MAX_BITRATE,
-          (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)));
+          (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS |
+              GST_PARAM_MUTABLE_PLAYING)));
 
   g_object_class_install_property (gobject_class, PROP_QP_MIN,
       g_param_spec_uint ("qp-min", "Minimum Quantizer",