ksmbd: Remove redundant 'flush_workqueue()' calls
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 10 Oct 2021 13:21:35 +0000 (15:21 +0200)
committerSteve French <stfrench@microsoft.com>
Sun, 7 Nov 2021 04:52:06 +0000 (23:52 -0500)
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

This was generated with coccinelle:

@@
expression E;
@@
-  flush_workqueue(E);
destroy_workqueue(E);

Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/ksmbd/ksmbd_work.c
fs/ksmbd/transport_rdma.c

index fd58eb4..14b9cae 100644 (file)
@@ -69,7 +69,6 @@ int ksmbd_workqueue_init(void)
 
 void ksmbd_workqueue_destroy(void)
 {
-       flush_workqueue(ksmbd_wq);
        destroy_workqueue(ksmbd_wq);
        ksmbd_wq = NULL;
 }
index a2fd5a4..6330dfc 100644 (file)
@@ -2043,7 +2043,6 @@ int ksmbd_rdma_destroy(void)
        smb_direct_listener.cm_id = NULL;
 
        if (smb_direct_wq) {
-               flush_workqueue(smb_direct_wq);
                destroy_workqueue(smb_direct_wq);
                smb_direct_wq = NULL;
        }