media: atmel-isi: drop unnecessary while loop
authorNicholas Mc Guire <hofrat@osadl.org>
Fri, 1 Jun 2018 12:46:14 +0000 (08:46 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 28 Jun 2018 10:49:59 +0000 (06:49 -0400)
As there is no way this can loop it actually makes no sense to have
a while(1){} around the body - all three possible paths end in a return
statement.

Fixes: commit c1d82b895380 "[media] atmel-isi: move out of soc_camera to atmel"

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/atmel/atmel-isi.c

index e5be21a..85fc7b9 100644 (file)
@@ -1106,23 +1106,21 @@ static int isi_graph_parse(struct atmel_isi *isi, struct device_node *node)
        struct device_node *ep = NULL;
        struct device_node *remote;
 
-       while (1) {
-               ep = of_graph_get_next_endpoint(node, ep);
-               if (!ep)
-                       return -EINVAL;
-
-               remote = of_graph_get_remote_port_parent(ep);
-               if (!remote) {
-                       of_node_put(ep);
-                       return -EINVAL;
-               }
+       ep = of_graph_get_next_endpoint(node, ep);
+       if (!ep)
+               return -EINVAL;
 
-               /* Remote node to connect */
-               isi->entity.node = remote;
-               isi->entity.asd.match_type = V4L2_ASYNC_MATCH_FWNODE;
-               isi->entity.asd.match.fwnode = of_fwnode_handle(remote);
-               return 0;
+       remote = of_graph_get_remote_port_parent(ep);
+       if (!remote) {
+               of_node_put(ep);
+               return -EINVAL;
        }
+
+       /* Remote node to connect */
+       isi->entity.node = remote;
+       isi->entity.asd.match_type = V4L2_ASYNC_MATCH_FWNODE;
+       isi->entity.asd.match.fwnode = of_fwnode_handle(remote);
+       return 0;
 }
 
 static int isi_graph_init(struct atmel_isi *isi)