x86/dumpstack: Add loglevel argument to show_opcodes()
authorBorislav Petkov <bp@suse.de>
Tue, 17 Apr 2018 16:11:20 +0000 (18:11 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 26 Apr 2018 14:15:26 +0000 (16:15 +0200)
Will be used in the next patch.

Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Link: https://lkml.kernel.org/r/20180417161124.5294-6-bp@alien8.de
arch/x86/include/asm/stacktrace.h
arch/x86/kernel/dumpstack.c

index 133d942..0630eeb 100644 (file)
@@ -111,4 +111,5 @@ static inline unsigned long caller_frame_pointer(void)
        return (unsigned long)frame;
 }
 
+void show_opcodes(u8 *rip, const char *loglvl);
 #endif /* _ASM_X86_STACKTRACE_H */
index 1d6698b..1592d0c 100644 (file)
@@ -70,14 +70,14 @@ static void printk_stack_address(unsigned long address, int reliable,
        printk("%s %s%pB\n", log_lvl, reliable ? "" : "? ", (void *)address);
 }
 
-static void show_opcodes(u8 *rip)
+void show_opcodes(u8 *rip, const char *loglvl)
 {
        unsigned int code_prologue = OPCODE_BUFSIZE * 2 / 3;
        u8 opcodes[OPCODE_BUFSIZE];
        u8 *ip;
        int i;
 
-       printk(KERN_DEFAULT "Code: ");
+       printk("%sCode: ", loglvl);
 
        ip = (u8 *)rip - code_prologue;
        if (probe_kernel_read(opcodes, ip, OPCODE_BUFSIZE)) {
@@ -401,6 +401,6 @@ void show_regs(struct pt_regs *regs)
                if (regs->ip < PAGE_OFFSET)
                        printk(KERN_DEFAULT "Code: Bad RIP value.\n");
                else
-                       show_opcodes((u8 *)regs->ip);
+                       show_opcodes((u8 *)regs->ip, KERN_DEFAULT);
        }
 }