Change checks for srca == 0 to src == 0
authorSøren Sandmann Pedersen <sandmann@redhat.com>
Fri, 26 Jun 2009 22:58:23 +0000 (18:58 -0400)
committerSøren Sandmann Pedersen <sandmann@redhat.com>
Fri, 26 Jun 2009 22:58:23 +0000 (18:58 -0400)
It is not generally correct to bail out just because the source alpha
is 0. The color channels still mig not be and in that case the correct
result is:

       s + (1 - srca) * d = s + d

which is not generally 0.

pixman/pixman-arm-neon.c

index b4f9a27..b88ede8 100644 (file)
@@ -1736,7 +1736,7 @@ fbCompositeSolidMask_nx8x0565neon (
 
        // bail out if fully transparent or degenerate
        srca = src >> 24;
-       if(srca == 0)
+       if(src == 0)
                return;
        if(width == 0 || height == 0)
                return;
@@ -1877,7 +1877,7 @@ fbCompositeSolid_nx0565neon (
 
        // bail out if fully transparent
        srca = src >> 24;
-       if(srca == 0)
+       if(src == 0)
                return;
        if(width == 0 || height == 0)
                return;