tools: gpio: fix spurious close warning in gpio-utils

Fix bogus close warning that occurs when opening the character device
fails.

Signed-off-by: Kent Gibson <warthog618@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

diff --git a/tools/gpio/gpio-utils.c b/tools/gpio/gpio-utils.c
index 06003789e7c7ed7e88f4c890e357eea822b97655..16a5d9cb9da280073ea7892ab342b8ded46a4370 100644 (file)
--- a/tools/gpio/gpio-utils.c
+++ b/tools/gpio/gpio-utils.c
@@ -75,7 +75,7 @@ int gpiotools_request_linehandle(const char *device_name, unsigned int *lines,
                ret = -errno;
                fprintf(stderr, "Failed to open %s, %s\n",
                        chrdev_name, strerror(errno));
-               goto exit_close_error;
+               goto exit_free_name;
        }
 
        for (i = 0; i < nlines; i++)
@@ -94,9 +94,9 @@ int gpiotools_request_linehandle(const char *device_name, unsigned int *lines,
                        "GPIO_GET_LINEHANDLE_IOCTL", ret, strerror(errno));
        }
 
-exit_close_error:
        if (close(fd) == -1)
                perror("Failed to close GPIO character device file");
+exit_free_name:
        free(chrdev_name);
        return ret < 0 ? ret : req.fd;
 }