e1000e: fix sparse warnings with -D__CHECK_ENDIAN__
authorBruce Allan <bruce.w.allan@intel.com>
Tue, 31 Jan 2012 06:37:32 +0000 (06:37 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 7 Feb 2012 12:16:54 +0000 (04:16 -0800)
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/e1000e/ethtool.c
drivers/net/ethernet/intel/e1000e/netdev.c

index fd2ba38..f4dc0fa 100644 (file)
@@ -553,7 +553,7 @@ static int e1000_set_eeprom(struct net_device *netdev,
        memcpy(ptr, bytes, eeprom->len);
 
        for (i = 0; i < last_word - first_word + 1; i++)
-               eeprom_buff[i] = cpu_to_le16(eeprom_buff[i]);
+               cpu_to_le16s(&eeprom_buff[i]);
 
        ret_val = e1000_write_nvm(hw, first_word,
                                  last_word - first_word + 1, eeprom_buff);
index a9f25fc..2ac1164 100644 (file)
@@ -183,18 +183,18 @@ static void e1000e_dump(struct e1000_adapter *adapter)
        struct e1000_ring *tx_ring = adapter->tx_ring;
        struct e1000_tx_desc *tx_desc;
        struct my_u0 {
-               u64 a;
-               u64 b;
+               __le64 a;
+               __le64 b;
        } *u0;
        struct e1000_buffer *buffer_info;
        struct e1000_ring *rx_ring = adapter->rx_ring;
        union e1000_rx_desc_packet_split *rx_desc_ps;
        union e1000_rx_desc_extended *rx_desc;
        struct my_u1 {
-               u64 a;
-               u64 b;
-               u64 c;
-               u64 d;
+               __le64 a;
+               __le64 b;
+               __le64 c;
+               __le64 d;
        } *u1;
        u32 staterr;
        int i = 0;
@@ -5963,7 +5963,8 @@ static void e1000_eeprom_checks(struct e1000_adapter *adapter)
                return;
 
        ret_val = e1000_read_nvm(hw, NVM_INIT_CONTROL2_REG, 1, &buf);
-       if (!ret_val && (!(le16_to_cpu(buf) & (1 << 0)))) {
+       le16_to_cpus(&buf);
+       if (!ret_val && (!(buf & (1 << 0)))) {
                /* Deep Smart Power Down (DSPD) */
                dev_warn(&adapter->pdev->dev,
                         "Warning: detected DSPD enabled in EEPROM\n");