drm/kirin: Set up fbdev after fully registering device
authorThomas Zimmermann <tzimmermann@suse.de>
Wed, 8 Apr 2020 08:26:34 +0000 (10:26 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Wed, 8 Apr 2020 14:24:40 +0000 (16:24 +0200)
Generic fbdev support is a DRM client. Set it up after fully registering
the new DRM device.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200408082641.590-4-tzimmermann@suse.de
drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c

index d3145ae877d74d766925d703326471d12134b17e..981858cc8d2b5290b4c15a54c1dabe28b03d6310 100644 (file)
@@ -277,8 +277,6 @@ static int kirin_drm_bind(struct device *dev)
        if (ret)
                goto err_kms_cleanup;
 
-       drm_fbdev_generic_setup(drm_dev, 32);
-
        /* connectors should be registered after drm device register */
        if (driver_data->register_connects) {
                ret = kirin_drm_connectors_register(drm_dev);
@@ -286,6 +284,8 @@ static int kirin_drm_bind(struct device *dev)
                        goto err_drm_dev_unregister;
        }
 
+       drm_fbdev_generic_setup(drm_dev, 32);
+
        return 0;
 
 err_drm_dev_unregister: