mfd: asic3: Add missing iounmap() on error asic3_mfd_probe
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 7 Mar 2022 07:29:47 +0000 (07:29 +0000)
committerLee Jones <lee.jones@linaro.org>
Wed, 23 Mar 2022 14:51:50 +0000 (14:51 +0000)
Add the missing iounmap() before return from asic3_mfd_probe
in the error handling case.

Fixes: 64e8867ba809 ("mfd: tmio_mmc hardware abstraction for CNF area")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20220307072947.5369-1-linmq006@gmail.com
drivers/mfd/asic3.c

index 8d58c8d..56338f9 100644 (file)
@@ -906,14 +906,14 @@ static int __init asic3_mfd_probe(struct platform_device *pdev,
                ret = mfd_add_devices(&pdev->dev, pdev->id,
                        &asic3_cell_ds1wm, 1, mem, asic->irq_base, NULL);
                if (ret < 0)
-                       goto out;
+                       goto out_unmap;
        }
 
        if (mem_sdio && (irq >= 0)) {
                ret = mfd_add_devices(&pdev->dev, pdev->id,
                        &asic3_cell_mmc, 1, mem_sdio, irq, NULL);
                if (ret < 0)
-                       goto out;
+                       goto out_unmap;
        }
 
        ret = 0;
@@ -927,8 +927,12 @@ static int __init asic3_mfd_probe(struct platform_device *pdev,
                ret = mfd_add_devices(&pdev->dev, 0,
                        asic3_cell_leds, ASIC3_NUM_LEDS, NULL, 0, NULL);
        }
+       return ret;
 
- out:
+out_unmap:
+       if (asic->tmio_cnf)
+               iounmap(asic->tmio_cnf);
+out:
        return ret;
 }