flow_offload: action should not be NULL when it is referenced
authorgushengxian <gushengxian@yulong.com>
Sat, 26 Jun 2021 11:56:06 +0000 (04:56 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jul 2021 07:44:55 +0000 (09:44 +0200)
[ Upstream commit 9ea3e52c5bc8bb4a084938dc1e3160643438927a ]

"action" should not be NULL when it is referenced.

Signed-off-by: gushengxian <13145886936@163.com>
Signed-off-by: gushengxian <gushengxian@yulong.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/net/flow_offload.h

index 123b1e9..161b909 100644 (file)
@@ -312,12 +312,14 @@ flow_action_mixed_hw_stats_check(const struct flow_action *action,
        if (flow_offload_has_one_action(action))
                return true;
 
-       flow_action_for_each(i, action_entry, action) {
-               if (i && action_entry->hw_stats != last_hw_stats) {
-                       NL_SET_ERR_MSG_MOD(extack, "Mixing HW stats types for actions is not supported");
-                       return false;
+       if (action) {
+               flow_action_for_each(i, action_entry, action) {
+                       if (i && action_entry->hw_stats != last_hw_stats) {
+                               NL_SET_ERR_MSG_MOD(extack, "Mixing HW stats types for actions is not supported");
+                               return false;
+                       }
+                       last_hw_stats = action_entry->hw_stats;
                }
-               last_hw_stats = action_entry->hw_stats;
        }
        return true;
 }