increase code quality(static analysis)

Change-Id: Iab1c3b1c2325253d9046d6981a5d0f59c3e305af

diff --git a/server/states/src/AuthenticateState.cpp b/server/states/src/AuthenticateState.cpp
index d1573bb..e7a55f8 100755 (executable)
--- a/server/states/src/AuthenticateState.cpp
+++ b/server/states/src/AuthenticateState.cpp
@@ -286,6 +286,7 @@ AuthenticateState::handle(IAuthStub *stub, AsmRequest *asmReq, const char *str,
                                if (recFound <= 0) {
                                        _ERR("No key registered for this app");
                                        searchRes->clear();
+                                       delete searchRes;
                                        return -1;
                                }
 

diff --git a/silent_auth/silent_auth_entry.cpp b/silent_auth/silent_auth_entry.cpp
index 32c4687..fc24cb4 100755 (executable)
--- a/silent_auth/silent_auth_entry.cpp
+++ b/silent_auth/silent_auth_entry.cpp
@@ -431,6 +431,7 @@ processAuthenticate(unsigned char *assert_req)
 
                                        UserNameKeyHandle *ukhInfoNew = ALLOC(UserNameKeyHandle);
                                        ukhInfoNew->userName = user_name;
+                                       user_name = NULL;
 
                                        ukhInfoNew->kh = ALLOC(Buffer);
                                        ukhInfoNew->kh->data = NALLOC(BIG_STRING_SIZE, uint8_t);
@@ -443,6 +444,9 @@ processAuthenticate(unsigned char *assert_req)
 
                                        response_parsed = true;
                                }
+                               SAFE_DELETE(pri_key);
+                               SAFE_DELETE(khA);
+                               SAFE_DELETE(user_name);
                         }
 
                        ukhIter = ukhIter->next;
@@ -773,18 +777,18 @@ processRegister(unsigned char *assert_req)
 
        unsigned int kh_str_enc_len = 0;
        unsigned char kh_str_enc[BIG_STRING_SIZE] = {0, };
-       kh_str_enc_len = AsmCrypto::aesEncrypt((const unsigned char*)kh_str,
+       ret = AsmCrypto::aesEncrypt((const unsigned char*)kh_str,
                                                                                                          strlen(kh_str),
                                                                                                          key,//(const unsigned char*)symKey.c_str(),
                                                                                                          iv,//(const unsigned char*)symKey.c_str(),
                                                                                                          kh_str_enc);
+       if (ret < 0)
+               kh_str_enc_len = 0;
+       else
+               kh_str_enc_len = ret;
 
        _INFO("After AESEncrypt, length = [%d]", kh_str_enc_len);
-       if (kh_str_enc_len > 0) {
-               kh_str_enc[kh_str_enc_len] = '\0';
-       } else {
-               kh_str_enc_len = 0;
-       }
+       kh_str_enc[kh_str_enc_len] = '\0';
 
        unsigned char digest[32];