clk: bcm: rpi: Use correct order for the parameters of devm_kcalloc()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 20 May 2022 21:20:58 +0000 (23:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Sep 2022 10:28:05 +0000 (12:28 +0200)
[ Upstream commit b7fa6242f3e035308a76284560e4f918dad9b017 ]

We should have 'n', then 'size', not the opposite.
This is harmless because the 2 values are just multiplied, but having
the correct order silence a (unpublished yet) smatch warning.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/49d726d11964ca0e3757bdb5659e3b3eaa1572b5.1653081643.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/bcm/clk-raspberrypi.c

index fda78a2f9ac504c7ff152932244d45b4eaa0969a..97612860ce0e10cec53a8720b10ebb86588c7ce1 100644 (file)
@@ -252,7 +252,7 @@ static int raspberrypi_discover_clocks(struct raspberrypi_clk *rpi,
        int ret;
 
        clks = devm_kcalloc(rpi->dev,
-                           sizeof(*clks), RPI_FIRMWARE_NUM_CLK_ID,
+                           RPI_FIRMWARE_NUM_CLK_ID, sizeof(*clks),
                            GFP_KERNEL);
        if (!clks)
                return -ENOMEM;