block: stub out and deprecated the capability attribute on the gendisk
authorChristoph Hellwig <hch@lst.de>
Fri, 3 Feb 2023 15:02:09 +0000 (16:02 +0100)
committerJens Axboe <axboe@kernel.dk>
Mon, 6 Feb 2023 15:44:55 +0000 (08:44 -0700)
The capability attribute was added in 2017 to expose the kernel internal
GENHD_FL_MEDIA_CHANGE_NOTIFY to userspace without ever adding a value to
an UAPI header, and without ever setting it in any driver until it was
finally removed in Linux 5.7.

Deprecate the file and always return 0 instead of exposing the other
internal and frequently renumbered other gendisk flags.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230203150209.3199115-1-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Documentation/block/capability.rst [deleted file]
Documentation/block/index.rst
block/genhd.c

diff --git a/Documentation/block/capability.rst b/Documentation/block/capability.rst
deleted file mode 100644 (file)
index 2ae7f06..0000000
+++ /dev/null
@@ -1,10 +0,0 @@
-===============================
-Generic Block Device Capability
-===============================
-
-This file documents the sysfs file ``block/<disk>/capability``.
-
-``capability`` is a bitfield, printed in hexadecimal, indicating which
-capabilities a specific block device supports:
-
-.. kernel-doc:: include/linux/blkdev.h
index c4c73db..1029531 100644 (file)
@@ -10,7 +10,6 @@ Block
    bfq-iosched
    biovecs
    blk-mq
-   capability
    cmdline-partition
    data-integrity
    deadline-iosched
index 705dec0..7e03155 100644 (file)
@@ -1024,9 +1024,8 @@ ssize_t part_inflight_show(struct device *dev, struct device_attribute *attr,
 static ssize_t disk_capability_show(struct device *dev,
                                    struct device_attribute *attr, char *buf)
 {
-       struct gendisk *disk = dev_to_disk(dev);
-
-       return sprintf(buf, "%x\n", disk->flags);
+       dev_warn_once(dev, "the capability attribute has been deprecated.\n");
+       return sprintf(buf, "0\n");
 }
 
 static ssize_t disk_alignment_offset_show(struct device *dev,