scsi: libsas: Call scsi_done() directly
authorBart Van Assche <bvanassche@acm.org>
Thu, 7 Oct 2021 20:28:40 +0000 (13:28 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:28:48 +0000 (21:28 -0400)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-46-bvanassche@acm.org
Reviewed-by: John Garry <john.garry@huawei.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/libsas/sas_scsi_host.c

index 2bf3715..d337fdf 100644 (file)
@@ -125,7 +125,7 @@ static void sas_scsi_task_done(struct sas_task *task)
        }
 
        sas_end_task(sc, task);
-       sc->scsi_done(sc);
+       scsi_done(sc);
 }
 
 static struct sas_task *sas_create_task(struct scsi_cmnd *cmd,
@@ -198,7 +198,7 @@ out_free_task:
        else
                cmd->result = DID_ERROR << 16;
 out_done:
-       cmd->scsi_done(cmd);
+       scsi_done(cmd);
        return 0;
 }
 EXPORT_SYMBOL_GPL(sas_queuecommand);