drm/amd/display: Early return on stream programming failure
authorLeo (Sunpeng) Li <sunpeng.li@amd.com>
Tue, 7 Nov 2017 20:54:58 +0000 (15:54 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 6 Dec 2017 17:47:41 +0000 (12:47 -0500)
The fail goto is incorrect. It will incorrectly release the dc_states on
stream programming failure.

Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Acked-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc.c

index e8ec2b0..3808b56 100644 (file)
@@ -899,7 +899,7 @@ static enum dc_status dc_commit_state_no_check(struct dc *dc, struct dc_state *c
        result = dc->hwss.apply_ctx_to_hw(dc, context);
 
        if (result != DC_OK)
-               goto fail;
+               return result;
 
        if (context->stream_count > 1) {
                enable_timing_multisync(dc, context);
@@ -938,7 +938,6 @@ static enum dc_status dc_commit_state_no_check(struct dc *dc, struct dc_state *c
                                context->streams[i]->timing.pix_clk_khz);
        }
 
-fail:
        dc_enable_stereo(dc, context, dc_streams, context->stream_count);
 
        dc_release_state(dc->current_state);