clk: qcom: gcc-x1e80100: Fix USB MP SS1 PHY GDSC pwrsts flags
authorAbel Vesa <abel.vesa@linaro.org>
Mon, 21 Oct 2024 12:46:25 +0000 (15:46 +0300)
committerBjorn Andersson <andersson@kernel.org>
Tue, 22 Oct 2024 20:35:15 +0000 (15:35 -0500)
Allowing these GDSCs to collapse makes the QMP combo PHYs lose their
configuration on machine suspend. Currently, the QMP combo PHY driver
doesn't reinitialise the HW on resume. Under such conditions, the USB
SuperSpeed support is broken. To avoid this, mark the pwrsts flags with
RET_ON. This has been already done for USB 0 and 1 SS PHY GDSCs,
Do this also for the USB MP SS1 PHY GDSC config. The USB MP SS0 PHY GDSC
already has it.

Fixes: 161b7c401f4b ("clk: qcom: Add Global Clock controller (GCC) driver for X1E80100")
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20241021-x1e80100-clk-gcc-fix-usb-mp-phy-gdsc-pwrsts-flags-v2-1-0bfd64556238@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/clk/qcom/gcc-x1e80100.c

index 81ba5ceab342f1c822c23f93efdc07ab80e1e83d..8ea25aa25dff043ab4a81fee78b6173139f871b6 100644 (file)
@@ -6155,7 +6155,7 @@ static struct gdsc gcc_usb3_mp_ss1_phy_gdsc = {
        .pd = {
                .name = "gcc_usb3_mp_ss1_phy_gdsc",
        },
-       .pwrsts = PWRSTS_OFF_ON,
+       .pwrsts = PWRSTS_RET_ON,
        .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
 };