wl1271: fix init loop timeout
authorLuciano Coelho <luciano.coelho@nokia.com>
Thu, 29 Oct 2009 11:20:04 +0000 (13:20 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 30 Oct 2009 20:50:39 +0000 (16:50 -0400)
The check after the loop which checks whether the initialization timed-out
was wrong.  If the initialization would succeed exactly in the 20000th time
(the value set for INIT_LOOP), the driver would bail out and claim that
initialization failed.

Reported-by: Juha Leppanen <juha_motorsportcom@luukku.com>
Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
Reviewed-by: Janne Ylalehto <janne.ylalehto@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/wl12xx/wl1271_boot.c

index ba4a2b4..8678bea 100644 (file)
@@ -380,7 +380,7 @@ static int wl1271_boot_run_firmware(struct wl1271 *wl)
                }
        }
 
-       if (loop >= INIT_LOOP) {
+       if (loop > INIT_LOOP) {
                wl1271_error("timeout waiting for the hardware to "
                             "complete initialization");
                return -EIO;