selftests/nolibc: mmap_munmap_good: fix up return value
authorZhangjin Wu <falcon@tinylab.org>
Tue, 25 Jul 2023 16:43:36 +0000 (00:43 +0800)
committerWilly Tarreau <w@1wt.eu>
Wed, 23 Aug 2023 03:17:07 +0000 (05:17 +0200)
The other tests use 1 as failure, mmap_munmap_good uses -1 as failure,
let's fix up this.

Signed-off-by: Zhangjin Wu <falcon@tinylab.org>
Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>
Signed-off-by: Willy Tarreau <w@1wt.eu>
tools/testing/selftests/nolibc/nolibc-test.c

index 3f5a256..4d39823 100644 (file)
@@ -726,7 +726,7 @@ int test_mmap_munmap(void)
 
        page_size = getpagesize();
        if (page_size < 0)
-               return -1;
+               return 1;
 
        /* find a right file to mmap, existed and accessible */
        for (i = 0; files[i] != NULL; i++) {
@@ -737,7 +737,7 @@ int test_mmap_munmap(void)
                        break;
        }
        if (ret == -1)
-               return ret;
+               return 1;
 
        ret = stat(files[i], &stat_buf);
        if (ret == -1)
@@ -757,7 +757,7 @@ int test_mmap_munmap(void)
 
        mem = mmap(NULL, length + offset - pa_offset, PROT_READ, MAP_SHARED, fd, pa_offset);
        if (mem == MAP_FAILED) {
-               ret = -1;
+               ret = 1;
                goto end;
        }
 
@@ -765,7 +765,7 @@ int test_mmap_munmap(void)
 
 end:
        close(fd);
-       return ret;
+       return !!ret;
 }