iris: Assert against FCV_CCS_E for blitter writes
authorNanley Chery <nanley.g.chery@intel.com>
Thu, 18 May 2023 18:10:03 +0000 (11:10 -0700)
committerMarge Bot <emma+marge@anholt.net>
Wed, 7 Jun 2023 23:39:39 +0000 (23:39 +0000)
The FCV feature is documented to occur on regular render writes. Blitter
writes don't fall under that category. So, if the destination resource
of a blitter write had the FCV aux usage, we would have a good reason to
change the aux usage of the access to plain CCS_E.

We don't actually need to write code to handle this. iris doesn't use
any compression on blitter writes. Make that obvious with an assert.

Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23220>

src/gallium/drivers/iris/iris_blit.c

index af9ed36..82d466a 100644 (file)
@@ -630,6 +630,10 @@ get_copy_region_aux_settings(struct iris_context *ice,
       bool is_zero = clear_color_is_fully_zero(res);
 
       if (batch->name == IRIS_BATCH_BLITTER) {
+
+         /* Compression isn't used for blitter destinations. */
+         assert(!is_dest);
+
          if (devinfo->verx10 >= 125) {
             *out_aux_usage = res->aux.usage;
             *out_clear_supported = is_zero;