net: dsa: hellcreek: Use the bitmap API to allocate bitmaps
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 9 Jul 2022 14:24:45 +0000 (16:24 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 12 Jul 2022 02:49:20 +0000 (19:49 -0700)
Use devm_bitmap_zalloc() instead of hand-writing them.

It is less verbose and it improves the semantic.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Kurt Kanzenbach <kurt@linutronix.de>
Link: https://lore.kernel.org/r/8306e2ae69a5d8553691f5d10a86a4390daf594b.1657376651.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/hirschmann/hellcreek.c

index ac1f3b3..01f9099 100644 (file)
@@ -1894,11 +1894,8 @@ static int hellcreek_probe(struct platform_device *pdev)
                if (!port->counter_values)
                        return -ENOMEM;
 
-               port->vlan_dev_bitmap =
-                       devm_kcalloc(dev,
-                                    BITS_TO_LONGS(VLAN_N_VID),
-                                    sizeof(unsigned long),
-                                    GFP_KERNEL);
+               port->vlan_dev_bitmap = devm_bitmap_zalloc(dev, VLAN_N_VID,
+                                                          GFP_KERNEL);
                if (!port->vlan_dev_bitmap)
                        return -ENOMEM;