ALSA: hda: cs35l41: Undo runtime PM changes at driver exit time
authorCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Thu, 7 Sep 2023 17:10:09 +0000 (20:10 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Nov 2023 10:59:18 +0000 (11:59 +0100)
[ Upstream commit 85a1bf86fac0c195929768b4e92c78cad107523b ]

According to the documentation, drivers are responsible for undoing at
removal time all runtime PM changes done during probing.

Hence, add the missing calls to pm_runtime_dont_use_autosuspend(), which
are necessary for undoing pm_runtime_use_autosuspend().

Fixes: 1873ebd30cc8 ("ALSA: hda: cs35l41: Support Hibernation during Suspend")
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20230907171010.1447274-11-cristian.ciocaltea@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/pci/hda/cs35l41_hda.c

index ebf9ddb..3c157b0 100644 (file)
@@ -1676,6 +1676,7 @@ int cs35l41_hda_probe(struct device *dev, const char *device_name, int id, int i
        return 0;
 
 err_pm:
+       pm_runtime_dont_use_autosuspend(cs35l41->dev);
        pm_runtime_disable(cs35l41->dev);
        pm_runtime_put_noidle(cs35l41->dev);
 
@@ -1694,6 +1695,7 @@ void cs35l41_hda_remove(struct device *dev)
        struct cs35l41_hda *cs35l41 = dev_get_drvdata(dev);
 
        pm_runtime_get_sync(cs35l41->dev);
+       pm_runtime_dont_use_autosuspend(cs35l41->dev);
        pm_runtime_disable(cs35l41->dev);
 
        if (cs35l41->halo_initialized)