ASoC: kirkwood-i2s: fix error return code in kirkwood_i2s_dev_probe()
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 30 Jun 2017 21:46:33 +0000 (16:46 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 17 Jul 2017 11:05:42 +0000 (12:05 +0100)
platform_get_irq() returns an error code, but the kirkwood-i2s
driver ignores it and always returns -ENXIO. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly.
Notice that platform_get_irq() no longer returns 0 on error.

Print and propagate the return value of platform_get_irq on failure.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/kirkwood/kirkwood-i2s.c

index 3a36d60..3b09f71 100644 (file)
@@ -550,9 +550,9 @@ static int kirkwood_i2s_dev_probe(struct platform_device *pdev)
                return PTR_ERR(priv->io);
 
        priv->irq = platform_get_irq(pdev, 0);
-       if (priv->irq <= 0) {
-               dev_err(&pdev->dev, "platform_get_irq failed\n");
-               return -ENXIO;
+       if (priv->irq < 0) {
+               dev_err(&pdev->dev, "platform_get_irq failed: %d\n", priv->irq);
+               return priv->irq;
        }
 
        if (np) {