mfd: dln2: Fix double put in dln2_probe
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Mon, 25 Sep 2023 02:41:33 +0000 (10:41 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Nov 2023 10:59:24 +0000 (11:59 +0100)
[ Upstream commit 759c409bc5fc496cbc22cd0b392d3cbb0c0e23eb ]

The dln2_free() already contains usb_put_dev(). Therefore,
the redundant usb_put_dev() before dln2_free() may lead to
a double free.

Fixes: 96da8f148396 ("mfd: dln2: Fix memory leak in dln2_probe()")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20230925024134.9683-1-dinghao.liu@zju.edu.cn
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mfd/dln2.c

index c7510434380a4376efb5b71b036b4bf8ae9d835e..fbbe82c6e75b5ce6b9a9d2c1ae3ad2c0e0463422 100644 (file)
@@ -826,7 +826,6 @@ out_stop_rx:
        dln2_stop_rx_urbs(dln2);
 
 out_free:
-       usb_put_dev(dln2->usb_dev);
        dln2_free(dln2);
 
        return ret;