Prevent returning of uninitialized values from cr_xml_dump.

diff --git a/src/load_metadata.h b/src/load_metadata.h
index 976d036ee0c4674c6a1c698aff6abfdd0fcb55d5..693de499336f30ac078479ee30dc7e4455ae406e 100644 (file)
--- a/src/load_metadata.h
+++ b/src/load_metadata.h
@@ -81,10 +81,6 @@ cr_HashTableKey cr_metadata_key(cr_Metadata *md);
  */
 GHashTable *cr_metadata_hashtable(cr_Metadata *md);
 
-// XXX TODO Remove
-/** Return GStringChunk from a cr_Metadata */
-//#define cr_metadata_chunk(X)        ((X)->chunk)
-
 /** Create new (empty) metadata hashtable.
  * It is NOT thread safe to load data into single cr_Metadata
  * from multiple threads. But non modifying access to the loaded data

diff --git a/src/xml_dump.c b/src/xml_dump.c
index f949c534e3687e14495bf8f07570170ebd39ddb7..69458f0b9bc199d4d81ee7d86c54ce61c2c19ad5 100644 (file)
--- a/src/xml_dump.c
+++ b/src/xml_dump.c
@@ -186,12 +186,12 @@ cr_xml_dump(cr_Package *pkg, GError **err)
 
     assert(!err || *err == NULL);
 
-    if (!pkg) {
-        result.primary   = NULL;
-        result.filelists = NULL;
-        result.other     = NULL;
+    result.primary   = NULL;
+    result.filelists = NULL;
+    result.other     = NULL;
+
+    if (!pkg)
         return result;
-    }
 
     result.primary = cr_xml_dump_primary(pkg, &tmp_err);
     if (tmp_err) {