staging: rtl8188eu: remove write-only power struct component
authorMartin Kaiser <martin@kaiser.cx>
Sun, 25 Jul 2021 15:58:54 +0000 (17:58 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Jul 2021 13:19:27 +0000 (15:19 +0200)
pwrpriv->bFwCurrentInPSMode is initialized and updated but nobody reads
its value. Remove this write-only component.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210725155902.32433-10-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h

index cbb34b9..f1af49a 100644 (file)
@@ -335,7 +335,6 @@ void rtw_set_ps_mode(struct adapter *padapter, u8 ps_mode, u8 smart_ps, u8 bcn_a
        /* if (pwrpriv->pwr_mode == PS_MODE_ACTIVE) */
        if (ps_mode == PS_MODE_ACTIVE) {
                if (PS_RDY_CHECK(padapter)) {
-                       pwrpriv->bFwCurrentInPSMode = true;
                        pwrpriv->pwr_mode = ps_mode;
                        pwrpriv->smart_ps = smart_ps;
                        pwrpriv->bcn_ant_mode = bcn_ant_mode;
@@ -461,8 +460,6 @@ void rtw_init_pwrctrl_priv(struct adapter *padapter)
                pwrctrlpriv->power_mgnt = padapter->registrypriv.power_mgnt;/*  PS_MODE_MIN; */
        pwrctrlpriv->bLeisurePs = (pwrctrlpriv->power_mgnt != PS_MODE_ACTIVE);
 
-       pwrctrlpriv->bFwCurrentInPSMode = false;
-
        pwrctrlpriv->rpwm = 0;
        pwrctrlpriv->cpwm = PS_STATE_S4;
 
index a676157..7bf807e 100644 (file)
@@ -95,9 +95,6 @@ void _8051Reset88E(struct adapter *padapter)
 
 void rtl8188e_InitializeFirmwareVars(struct adapter *padapter)
 {
-       /*  Init Fw LPS related. */
-       padapter->pwrctrlpriv.bFwCurrentInPSMode = false;
-
        /*  Init H2C counter. by tynli. 2009.12.09. */
        padapter->HalData->LastHMEBoxNum = 0;
 }
index 4345dc0..78febd3 100644 (file)
@@ -174,7 +174,6 @@ struct pwrctrl_priv {
        bool    bLeisurePs;
        u8      LpsIdleCount;
        u8      power_mgnt;
-       u8      bFwCurrentInPSMode;
        u32     DelayLPSLastTimeStamp;
        u8      btcoex_rfon;
        s32             pnp_current_pwr_state;