tools/power/x86/intel-speed-select: Change debug to error
authorSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Sat, 21 Mar 2020 00:17:15 +0000 (17:17 -0700)
committerSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Mon, 11 May 2020 18:29:52 +0000 (11:29 -0700)
When turbo-freq is enabled, we can't disable core-power. Currently
it prints debug message to warn. Change this to error message.

While here remove "\n" from calls to isst_display_error_info_message(),
as it will be added again during actual print.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
tools/power/x86/intel-speed-select/isst-core.c

index 67c9b11..a7f4337 100644 (file)
@@ -912,16 +912,16 @@ int isst_pm_qos_config(int cpu, int enable_clos, int priority_type)
                        return ret;
 
                if (ctdp_level.fact_enabled) {
-                       debug_printf("Turbo-freq feature must be disabled first\n");
+                       isst_display_error_info_message(1, "Ignoring request, turbo-freq feature is still enabled", 0, 0);
                        return -EINVAL;
                }
                ret = isst_write_pm_config(cpu, 0);
                if (ret)
-                       isst_display_error_info_message(0, "WRITE_PM_CONFIG command failed, ignoring error\n", 0, 0);
+                       isst_display_error_info_message(0, "WRITE_PM_CONFIG command failed, ignoring error", 0, 0);
        } else {
                ret = isst_write_pm_config(cpu, 1);
                if (ret)
-                       isst_display_error_info_message(0, "WRITE_PM_CONFIG command failed, ignoring error\n", 0, 0);
+                       isst_display_error_info_message(0, "WRITE_PM_CONFIG command failed, ignoring error", 0, 0);
        }
 
        ret = isst_send_mbox_command(cpu, CONFIG_CLOS, CLOS_PM_QOS_CONFIG, 0, 0,