p54: clamp properly instead of just truncating

commit 608cfbe4abaf76e9d732efd7ed1cfa3998163d91 upstream.

The call to clamp_t() first truncates the variable signed 8 bit and as a
result, the actual clamp is a no-op.

Fixes: 0d78156eef1d ('p54: improve site survey')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/net/wireless/p54/txrx.c b/drivers/net/wireless/p54/txrx.c
index a08a6f0..2933819 100644 (file)
--- a/drivers/net/wireless/p54/txrx.c
+++ b/drivers/net/wireless/p54/txrx.c
@@ -583,7 +583,7 @@ static void p54_rx_stats(struct p54_common *priv, struct sk_buff *skb)
        chan = priv->curchan;
        if (chan) {
                struct survey_info *survey = &priv->survey[chan->hw_value];
-               survey->noise = clamp_t(s8, priv->noise, -128, 127);
+               survey->noise = clamp(priv->noise, -128, 127);
                survey->channel_time = priv->survey_raw.active;
                survey->channel_time_tx = priv->survey_raw.tx;
                survey->channel_time_busy = priv->survey_raw.tx +