decodebin3: Remove spurious input locking during parsebin reconfiguration
authorPhilippe Normand <philn@igalia.com>
Wed, 12 Jul 2023 16:08:32 +0000 (17:08 +0100)
committerTim-Philipp Müller <tim@centricular.com>
Wed, 12 Jul 2023 19:32:53 +0000 (21:32 +0200)
Commit 22917b140ffac5208eff173321fa7cdad8976cca added extra locks in
`reset_input_parsebin()` but all call sites of that function already take the
input lock.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5025>

subprojects/gst-plugins-base/gst/playback/gstdecodebin3.c

index 916916e..e45ab0a 100644 (file)
@@ -1035,7 +1035,6 @@ reset_input_parsebin (GstDecodebin3 * dbin, DecodebinInput * input)
 
   GST_DEBUG_OBJECT (dbin, "Resetting %" GST_PTR_FORMAT, input->parsebin);
 
-  INPUT_LOCK (dbin);
   GST_STATE_LOCK (dbin);
   gst_element_set_state (input->parsebin, GST_STATE_NULL);
   input->drained = FALSE;
@@ -1048,7 +1047,6 @@ reset_input_parsebin (GstDecodebin3 * dbin, DecodebinInput * input)
   }
   gst_element_sync_state_with_parent (input->parsebin);
   GST_STATE_UNLOCK (dbin);
-  INPUT_UNLOCK (dbin);
 }