crypto: omap-aes - remove the sysfs group during driver removal
authorTero Kristo <t-kristo@ti.com>
Tue, 5 Nov 2019 14:00:52 +0000 (16:00 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 11 Dec 2019 08:36:57 +0000 (16:36 +0800)
The driver removal should also cleanup the created sysfs group. If not,
the driver fails the subsequent probe as the files exist already. Also,
drop a completely unnecessary pointer assignment from the removal
function at the same time.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/omap-aes.c

index a1fc03e..38c750e 100644 (file)
@@ -1296,7 +1296,8 @@ static int omap_aes_remove(struct platform_device *pdev)
        tasklet_kill(&dd->done_task);
        omap_aes_dma_cleanup(dd);
        pm_runtime_disable(dd->dev);
-       dd = NULL;
+
+       sysfs_remove_group(&dd->dev->kobj, &omap_aes_attr_group);
 
        return 0;
 }