[colorselector] backport r82456: Fix potential problem which would cause resource...

SVN revision: 82551

diff --git a/ChangeLog b/ChangeLog
index e75e2c771410484be55e7c47f9a1b59df642cdf9..5817af55c403ba741584c97cbde66838cd68a8a9 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -698,3 +698,7 @@
 2013-01-08  Jaehwan Kim
 
         * Fix the bug which the callbacks of the sub-object are added even if the sub-object is added the parent object.
+
+2013-01-10  Shinwoo Kim
+
+       * backport r82456: Fix potential problem which would cause resource leak.

diff --git a/NEWS b/NEWS
index 25468558acc4e8bc399e3e9b35136d13f3ff5f42..ab55d845b1b5af5eed698119c73dfd5a3a5d8e46 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -5,6 +5,7 @@ Changes since Elementary 1.7.5:
 
 Fixes:
 
+   * Fix potential problem which would cause resource leak.
    * Fix omitting signal emission when customized text parts change the text.
    * Fix the bug which the callbacks of the sub-object are added even if the sub-object is added the parent object.
 

diff --git a/src/lib/elm_colorselector.c b/src/lib/elm_colorselector.c
index f30af765e7bbf61043c1f320ef0a9ea627dc419d..589e5ed0b55953bbe73d35d5be43c26be964c68e 100644 (file)
--- a/src/lib/elm_colorselector.c
+++ b/src/lib/elm_colorselector.c
@@ -869,7 +869,6 @@ _access_info_cb(void *data,
 {
    char *ret;
    Eina_Strbuf *buf;
-   buf = eina_strbuf_new();
    int r = 0, g = 0, b = 0 ,a = 0;
 
    Elm_Color_Item *it = data;
@@ -877,6 +876,7 @@ _access_info_cb(void *data,
 
    elm_colorselector_palette_item_color_get((Elm_Object_Item *)it, &r, &g, &b, &a);
 
+   buf = eina_strbuf_new();
    eina_strbuf_append_printf(buf, "red %d, green %d, blue %d, alpha %d", r, g, b, a);
    ret = eina_strbuf_string_steal(buf);
    eina_strbuf_free(buf);